From: David Miller <davem@redhat.com>
To: eric.dumazet@gmail.com
Cc: luto@amacapital.net, x86@kernel.org,
torvalds@linux-foundation.org, mikey@neuling.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, trinity@vger.kernel.org
Subject: Re: [PATCH] net: Unbreak compat_sys_{send,recv}msg
Date: Thu, 06 Jun 2013 11:53:52 -0700 (PDT) [thread overview]
Message-ID: <20130606.115352.641926194470746732.davem@redhat.com> (raw)
In-Reply-To: <1370526337.24311.335.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 06 Jun 2013 06:45:37 -0700
> On Thu, 2013-06-06 at 00:26 -0700, David Miller wrote:
>> From: Andy Lutomirski <luto@amacapital.net>
>> Date: Wed, 5 Jun 2013 22:38:26 -0700
>>
>> > I broke them in this commit:
>> >
>> > commit 1be374a0518a288147c6a7398792583200a67261
>> > Author: Andy Lutomirski <luto@amacapital.net>
>> > Date: Wed May 22 14:07:44 2013 -0700
>> >
>> > net: Block MSG_CMSG_COMPAT in send(m)msg and recv(m)msg
>> >
>> > This patch adds __sys_sendmsg and __sys_sendmsg as common helpers that accept
>> > MSG_CMSG_COMPAT and blocks MSG_CMSG_COMPAT at the syscall entrypoints. It
>> > also reverts some unnecessary checks in sys_socketcall.
>> >
>> > Apparently I was suffering from underscore blindness the first time around.
>> >
>> > Signed-off-by: Andy Lutomirski <luto@amacapital.net>
>>
>> Eric, can you test this patch too?
>
> Yes, this fixes the problem as well on x86_64
>
> Tested-by: Eric Dumazet <edumazet@google.com>
Applied, thanks.
next prev parent reply other threads:[~2013-06-06 18:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 21:07 [PATCH 0/5] x86: oops on uaccess faults outside of user addresses Andy Lutomirski
2013-05-22 21:07 ` [PATCH 1/5] x86: Split "utter crap" pnpbios fixup out of fixup_exception Andy Lutomirski
2013-05-22 21:07 ` [PATCH 2/5] x86: Clean up extable entry format (and free up a bit) Andy Lutomirski
2013-05-22 21:07 ` [PATCH 3/5] x86: Annotate _ASM_EXTABLE users to distinguish uaccess from everything else Andy Lutomirski
2013-05-22 21:07 ` [PATCH 4/5] x86: Don't fixup uaccess faults to kernel or non-canonical addresses Andy Lutomirski
2013-05-22 21:07 ` [PATCH 5/5] net: Block MSG_CMSG_COMPAT in send(m)msg and recv(m)msg Andy Lutomirski
2013-05-28 8:56 ` [PATCH/FIX] " Ingo Molnar
2013-05-29 6:56 ` David Miller
2013-05-29 8:11 ` Ingo Molnar
2013-06-06 2:56 ` [PATCH 5/5] " Michael Neuling
2013-06-06 3:01 ` Anton Blanchard
2013-06-06 3:29 ` Stephen Rothwell
2013-06-06 5:38 ` [PATCH] net: Unbreak compat_sys_{send,recv}msg Andy Lutomirski
2013-06-06 5:48 ` Michael Neuling
2013-06-06 7:26 ` David Miller
2013-06-06 13:45 ` Eric Dumazet
2013-06-06 18:53 ` David Miller [this message]
2013-06-06 4:35 ` [PATCH 5/5] net: Block MSG_CMSG_COMPAT in send(m)msg and recv(m)msg Eric Dumazet
2013-06-06 5:00 ` David Miller
2013-05-22 21:28 ` [PATCH 0/5] x86: oops on uaccess faults outside of user addresses David Miller
2013-05-28 8:25 ` Ingo Molnar
2013-05-28 8:51 ` David Miller
2013-05-28 8:54 ` Ingo Molnar
2013-06-13 22:00 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606.115352.641926194470746732.davem@redhat.com \
--to=davem@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=luto@amacapital.net \
--cc=mikey@neuling.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trinity@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®