From: Borislav Petkov <bp@alien8.de>
To: Matt Fleming <matt@console-pimps.org>
Cc: Linux EFI <linux-efi@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Jiri Kosina <jkosina@suse.cz>, X86-ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH 4/4] x86, efi: Map runtime services 1:1
Date: Thu, 6 Jun 2013 17:58:22 +0200 [thread overview]
Message-ID: <20130606155822.GH20972@pd.tnic> (raw)
In-Reply-To: <20130606132908.GE20972@pd.tnic>
On Thu, Jun 06, 2013 at 03:29:08PM +0200, Borislav Petkov wrote:
> On Thu, Jun 06, 2013 at 02:14:39PM +0100, Matt Fleming wrote:
> > This patch makes my TunnelMountain machine spin in handle_pte_fault()
> > when triggering one of the "firmware makes references to physical
> > addresses" code paths.
> >
> > I'll try and dig into this tomorrow to figure out what's going on.
>
> Hmmm, looks like we have forgotten to map an EFI region and we do a #PF
> when executing the EFI code.
How about this one - I don't know whether it would flood dmesg, I guess
you'll have to try.
We could try using blockconsole to catch dmesg to an usb drive, though,
even if you don't have serial or netconsole or such. :-).
--
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index 654be4ae3047..7a6129afdff1 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -1021,6 +1021,9 @@ __do_page_fault(struct pt_regs *regs, unsigned long error_code)
/* Get the faulting address: */
address = read_cr2();
+ if (read_cr3() == (unsigned long)real_mode_header->trampoline_pgd)
+ pr_err("%s: #PF addr: 0x%lx\n", __func__, address);
+
/*
* Detect and handle instructions that would cause a page fault for
* both a tracked kernel page and a userspace page.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-06-06 15:58 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-02 12:56 [PATCH 0/4] EFI 1:1 mapping Borislav Petkov
2013-06-02 12:56 ` [PATCH 1/4] efi: Convert runtime services function ptrs Borislav Petkov
2013-06-06 10:07 ` Matt Fleming
2013-06-11 6:49 ` Matt Fleming
2013-06-11 9:33 ` Borislav Petkov
2013-06-02 12:56 ` [PATCH 2/4] x86, cpa: Map in an arbitrary pgd Borislav Petkov
2013-06-06 10:22 ` Matt Fleming
2013-06-06 13:24 ` Borislav Petkov
2013-06-06 13:30 ` Matt Fleming
2013-06-06 13:33 ` Borislav Petkov
2013-06-02 12:56 ` [PATCH 3/4] x86, efi: Add an efi= kernel command line parameter Borislav Petkov
2013-06-04 12:18 ` Borislav Petkov
2013-06-06 10:42 ` Matt Fleming
2013-06-06 13:26 ` Borislav Petkov
2013-06-06 13:36 ` Matt Fleming
2013-06-06 17:50 ` Matthew Garrett
2013-06-06 18:51 ` Borislav Petkov
2013-06-06 19:35 ` Matthew Garrett
2013-06-06 19:41 ` Borislav Petkov
2013-06-06 19:54 ` Matthew Garrett
2013-06-06 20:07 ` Borislav Petkov
2013-06-06 20:18 ` Matthew Garrett
2013-06-06 20:27 ` Borislav Petkov
2013-06-06 20:30 ` Matthew Garrett
2013-06-06 20:44 ` Borislav Petkov
2013-06-06 20:50 ` Matthew Garrett
2013-06-06 21:02 ` Borislav Petkov
2013-06-06 21:03 ` Matthew Garrett
2013-06-02 12:56 ` [PATCH 4/4] x86, efi: Map runtime services 1:1 Borislav Petkov
2013-06-06 13:14 ` Matt Fleming
2013-06-06 13:29 ` Borislav Petkov
2013-06-06 15:58 ` Borislav Petkov [this message]
2013-06-06 19:28 ` H. Peter Anvin
2013-06-06 19:36 ` Borislav Petkov
2013-06-06 19:38 ` H. Peter Anvin
2013-06-10 12:55 ` Borislav Petkov
2013-06-02 22:56 ` [PATCH 0/4] EFI 1:1 mapping Matthew Garrett
2013-06-03 8:11 ` Borislav Petkov
2013-06-03 14:27 ` James Bottomley
2013-06-03 14:30 ` Matthew Garrett
2013-06-03 14:38 ` James Bottomley
2013-06-03 15:21 ` Matthew Garrett
2013-06-03 16:18 ` James Bottomley
2013-06-03 16:24 ` Matthew Garrett
2013-06-03 16:35 ` James Bottomley
2013-06-03 16:42 ` Matthew Garrett
2013-06-03 18:05 ` James Bottomley
2013-06-03 18:11 ` Matthew Garrett
2013-06-03 21:19 ` James Bottomley
2013-06-03 21:29 ` Matthew Garrett
2014-02-10 3:59 ` Linux, UEFI, and Chromebooks (was RE: [PATCH 0/4] EFI 1:1 mapping) Yuhong Bao
2013-06-03 14:32 ` [PATCH 0/4] EFI 1:1 mapping Matthew Garrett
2013-06-03 14:54 ` Matt Fleming
2013-06-04 8:15 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606155822.GH20972@pd.tnic \
--to=bp@alien8.de \
--cc=bp@suse.de \
--cc=jkosina@suse.cz \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome