From: Adam Lee <adam.lee@canonical.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
Alex Hung <alex.hung@canonical.com>, Bjorn Mork <bjorn@mork.no>
Subject: Re: [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs
Date: Sat, 8 Jun 2013 17:04:33 +0800 [thread overview]
Message-ID: <20130608090433.GB7334@adam-laptop> (raw)
In-Reply-To: <1370636175.13515.140661241274985.19126A97@webmail.messagingengine.com>
On Fri, Jun 07, 2013 at 05:16:15PM -0300, Henrique de Moraes Holschuh wrote:
> Can you get me the ACPI interface documentation? It should be simple
> to get it, but I haven't emailed the Lenovo BIOS engineers for some
> time.
>
> Basically, create a new LED method in thinkpad-acpi, lock it down to
> vendor lenovo, detect the new interfaces, and only check the
> two-argument LED one if the newer ones aren't found.
>
> Not supporting the old /proc interface on new thinkpads is fine.
Thanks, I will request the documentation from Lenovo again.
Please apply "[PATCH 1/3 v3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs" and
"[PATCH 2/3] thinkpad_acpi: add the ability setting TPACPI_LED_NONE by quirk", but
hold "[PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs",
I will drop [PATCH 3/3] to discussion again when I got the documentation.
--
Regards,
Adam Lee
Hardware Enablement
next prev parent reply other threads:[~2013-06-08 9:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 8:20 [PATCH 0/3] thinkpad_acpi: avoid ACPI Warning while operating non-exist LEDs Adam Lee
2013-06-07 8:20 ` [PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs Adam Lee
2013-06-07 8:53 ` Bjørn Mork
2013-06-07 8:59 ` Adam Lee
2013-06-18 0:12 ` Henrique de Moraes Holschuh
2013-06-18 0:18 ` Henrique de Moraes Holschuh
2013-06-07 8:20 ` [PATCH 2/3] thinkpad_acpi: add the ability setting TPACPI_LED_NONE by quirk Adam Lee
2013-06-18 0:19 ` Henrique de Moraes Holschuh
2013-06-07 8:20 ` [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs Adam Lee
2013-06-07 13:22 ` Matthew Garrett
2013-06-07 15:06 ` Adam Lee
2013-06-07 20:16 ` Henrique de Moraes Holschuh
2013-06-08 9:04 ` Adam Lee [this message]
2013-06-18 0:20 ` Henrique de Moraes Holschuh
2013-06-07 9:05 ` [PATCH v2] thinkpad_acpi: return -NODEV while operating uninitialized LEDs Adam Lee
2013-06-08 2:19 ` Amos Kong
2013-06-08 8:51 ` [PATCH 1/3 v3] " Adam Lee
2013-06-18 0:17 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130608090433.GB7334@adam-laptop \
--to=adam.lee@canonical.com \
--cc=alex.hung@canonical.com \
--cc=bjorn@mork.no \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®