Re: [RFC] scripts/setlocalversion on write-protected source tree

[Nico Schottelius <nico-linuxsetlocalversion@schottelius.org>]

Hey Christian,

Christian Kujau [Sun, Jun 09, 2013 at 05:50:49PM -0700]:
> Hi,
> 
> [errors when using git update-index - different scenarios]
> [...]
> 
> On a side note, I don't think a kernel compilation should alter the source 
> tree (or the .git directory) in any way and I don't see how removing 
> "git update-index" could do any harm. The Mercurial and SVN routines in 
> scripts/setlocalversion don't have any tree-modifying commands, AFAICS. 
> So, maybe the attached patch would be acceptable.
> 
> [...]

As --refresh is being used, I guess (!) the motivation was to update the
index for stat changes that may have taken place elsewhere (like on
NFS) - not sure whether this actually matches (can somebody confirm /
overturn this theory?).

I do however agree with you that setlocalversion should probably not
try to fix this problem, but leave it to the user to update the index,
if necessary.

So I'd personally go for your second patch.

Cheers,

Nico

> diff --git a/scripts/setlocalversion b/scripts/setlocalversion
> index 84b88f1..d105a44 100755
> --- a/scripts/setlocalversion
> +++ b/scripts/setlocalversion
> @@ -71,9 +71,6 @@ scm_version()
>  			printf -- '-svn%s' "`git svn find-rev $head`"
>  		fi
>  
> -		# Update index only on r/w media
> -		[ -w . ] && git update-index --refresh --unmerged > /dev/null
> -
>  		# Check for uncommitted changes
>  		if git diff-index --name-only HEAD | grep -qv "^scripts/package"; then
>  			printf '%s' -dirty


-- 
PGP key: 7ED9 F7D3 6B10 81D7 0EC5  5C09 D7DC C8E4 3187 7DF0