mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	SH-Linux <linux-sh@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-leds@vger.kernel.org,
	Thierry Reding <thierry.reding@avionic-design.de>,
	Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH v3 3/5] ARM: mach-shmobile: kota2: Use leds-pwm + pwm-rmob
Date: Wed, 12 Jun 2013 14:47:44 +0900	[thread overview]
Message-ID: <20130612054741.GB20803@verge.net.au> (raw)
In-Reply-To: <CANqRtoR=anJ+2RWWxSw-YwiczfTD1jwz=odX8n1U1FrJtYT_zA@mail.gmail.com>

On Wed, Jun 12, 2013 at 02:33:16PM +0900, Magnus Damm wrote:
> Hi Laurent,
> 
> [Added Simon to CC]
> 
> Thanks for your work on converting the TPU driver. I found one issue, see below:
> 
> On Tue, Jun 11, 2013 at 10:45 PM, Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
> > Instead of using the LED-specific TPU PWM driver, switch to the generic
> > TPU PWM driver with leds-pwm.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/mach-shmobile/board-kota2.c  | 183 ++++++++++++++++++++--------------
> >  arch/arm/mach-shmobile/clock-sh73a0.c |   8 +-
> >  2 files changed, 114 insertions(+), 77 deletions(-)
> >
> 
> [snip]
> 
> > diff --git a/arch/arm/mach-shmobile/clock-sh73a0.c b/arch/arm/mach-shmobile/clock-sh73a0.c
> > index d9fd033..6c04348 100644
> > --- a/arch/arm/mach-shmobile/clock-sh73a0.c
> > +++ b/arch/arm/mach-shmobile/clock-sh73a0.c
> > @@ -669,10 +669,10 @@ static struct clk_lookup lookups[] = {
> >         CLKDEV_DEV_ID("e6bd0000.mmcif", &mstp_clks[MSTP312]), /* MMCIF0 */
> >         CLKDEV_DEV_ID("sh_mobile_sdhi.2", &mstp_clks[MSTP311]), /* SDHI2 */
> >         CLKDEV_DEV_ID("ee140000.sdhi", &mstp_clks[MSTP311]), /* SDHI2 */
> > -       CLKDEV_DEV_ID("leds-renesas-tpu.12", &mstp_clks[MSTP303]), /* TPU1 */
> > -       CLKDEV_DEV_ID("leds-renesas-tpu.21", &mstp_clks[MSTP302]), /* TPU2 */
> > -       CLKDEV_DEV_ID("leds-renesas-tpu.30", &mstp_clks[MSTP301]), /* TPU3 */
> > -       CLKDEV_DEV_ID("leds-renesas-tpu.41", &mstp_clks[MSTP300]), /* TPU4 */
> > +       CLKDEV_DEV_ID("rmob_tpu_pwm.1", &mstp_clks[MSTP303]), /* TPU1 */
> > +       CLKDEV_DEV_ID("rmob_tpu_pwm.2", &mstp_clks[MSTP302]), /* TPU2 */
> > +       CLKDEV_DEV_ID("rmob_tpu_pwm.3", &mstp_clks[MSTP301]), /* TPU3 */
> > +       CLKDEV_DEV_ID("rmob_tpu_pwm.4", &mstp_clks[MSTP300]), /* TPU4 */
> >         CLKDEV_DEV_ID("i2c-sh_mobile.3", &mstp_clks[MSTP411]), /* I2C3 */
> >         CLKDEV_DEV_ID("e6826000.i2c", &mstp_clks[MSTP411]), /* I2C3 */
> >         CLKDEV_DEV_ID("i2c-sh_mobile.4", &mstp_clks[MSTP410]), /* I2C4 */
> > --
> > 1.8.1.5
> >
> 
> I believe you are using the old "rmob" device name in the hunk above.
> Apart from that it looks fine.
> 
> I left my Kota2 board at Simon's place some time ago so I'm afraind
> that I can't test. Given the complexity with multiple subsystems and
> also recent name changes, perhaps testing this would make sense?
> 
> Simon, can you please test this series on Kota2?

Sure.

Laurent could you re-post the series with the "rmob" problem resolved?

  reply	other threads:[~2013-06-12  5:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11 13:45 [PATCH v3 0/5] Renesas TPU PWM support Laurent Pinchart
2013-06-11 13:45 ` [PATCH v3 1/5] pwm: Add Renesas TPU PWM driver Laurent Pinchart
2013-06-12 10:22   ` Thierry Reding
2013-06-13 15:39     ` Laurent Pinchart
2013-06-11 13:45 ` [PATCH v3 2/5] ARM: mach-shmobile: armadillo800eva: Add backlight support Laurent Pinchart
2013-06-11 13:45 ` [PATCH v3 3/5] ARM: mach-shmobile: kota2: Use leds-pwm + pwm-rmob Laurent Pinchart
2013-06-12  5:33   ` Magnus Damm
2013-06-12  5:47     ` Simon Horman [this message]
2013-06-11 13:45 ` [PATCH v3 4/5] ARM: shmobile: sh73a0: Remove all GPIOs Laurent Pinchart
2013-06-11 13:45 ` [PATCH v3 5/5] leds: Remove leds-renesas-tpu driver Laurent Pinchart
2013-06-12 10:12 ` [PATCH v3 0/5] Renesas TPU PWM support Thierry Reding
2013-06-13 15:38   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130612054741.GB20803@verge.net.au \
    --to=horms@verge.net.au \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®