From: Andrew Morton <akpm@linux-foundation.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [RFC: PATCH] err.h: silence warning when using IS_ERR on void __iomem *
Date: Thu, 13 Jun 2013 13:14:15 -0700 [thread overview]
Message-ID: <20130613131415.aa4f675f151c586f5f6b2123@linux-foundation.org> (raw)
In-Reply-To: <20130613182447.GB32574@mithrandir>
On Thu, 13 Jun 2013 20:24:48 +0200 Thierry Reding <thierry.reding@gmail.com> wrote:
> On Thu, Jun 13, 2013 at 10:55:17AM +0530, Sachin Kamat wrote:
> > On 13 June 2013 03:01, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > > Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
> > > introduced devm_ioremap_resource() and encourage to check its return value with
> > > IS_ERR(). This however leads to the following sparse warnings, as
> > > devm_ioremap_resource() returns a void __iomem pointer:
> > >
> > > drivers/net/can/c_can/c_can_platform.c:205:32: warning: incorrect type in argument 1 (different address spaces)
> > > drivers/net/can/c_can/c_can_platform.c:205:32: expected void const *ptr
> > > drivers/net/can/c_can/c_can_platform.c:205:32: got unsigned int [noderef] [usertype] <asn:2>*raminit_ctrlreg
> >
> > CC ing Thierry who has solved this issue some time back.
>
> I had sent two patches, one against sparse, the other against the
> kernel, but none were picked up yet.
I didn't know that.
On May 8 I queued
http://ozlabs.org/~akpm/mmots/broken-out/errh-is_err-can-accept-__user-pointers.patch.
Dan says that sparse v0.4.5-rc1 or later is also required.
next prev parent reply other threads:[~2013-06-13 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 21:31 Marc Kleine-Budde
2013-06-13 5:25 ` Sachin Kamat
2013-06-13 18:24 ` Thierry Reding
2013-06-13 19:19 ` Marc Kleine-Budde
2013-06-13 20:14 ` Andrew Morton [this message]
2013-06-13 21:39 ` Thierry Reding
2013-06-17 7:59 ` Dan Carpenter
2013-06-17 10:11 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613131415.aa4f675f151c586f5f6b2123@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=sachin.kamat@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®