mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Colin Cross <ccross@android.com>
Cc: linux-arm-kernel@lists.infradead.org,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: convert max_pfn and max_low_pfn to be relative to PFN0
Date: Thu, 13 Jun 2013 18:37:23 +0100	[thread overview]
Message-ID: <20130613173723.GK18614@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1371089603-22601-1-git-send-email-ccross@android.com>

On Wed, Jun 12, 2013 at 07:13:23PM -0700, Colin Cross wrote:
> >From code inspection, I believe this will also improve block device
> performance where the bounce limit was set to BLK_BOUNCE_HIGH, which
> was bouncing unnecessarily for the top PHYS_PFN_OFFSET pages of low
> memory.

This has the potential to break platforms.  The problem is the duality
of the dma_mask - is it a mask of the bits which the device can drive,
or a PFN limit.  The block layer interprets it as a PFN limit, because
of course everywhere starts their memory at physical address zero.

This gets into a world of pain if you have any of these conditions:
(a) RAM not starting at physical address zero
(b) Any translation between physical addresses and bus addresses

What we know is that the existing stuff works.  What we don't know is
whether changing it will break anything which falls into the above
two categories.

  reply	other threads:[~2013-06-13 17:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  2:13 Colin Cross
2013-06-13 17:37 ` Russell King - ARM Linux [this message]
2013-06-13 18:30   ` Colin Cross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130613173723.GK18614@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=ccross@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®