mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andi Shyti <andi@etezian.org>
Cc: arnd@arndb.de, rob@landley.net, oatilla@gmail.com,
	szsolt@gmail.com, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH 0/2] etzkx accelerometer support
Date: Sun, 16 Jun 2013 19:58:54 -0700	[thread overview]
Message-ID: <20130617025854.GB12522@kroah.com> (raw)
In-Reply-To: <20130616222648.GE4385@jack.whiskey>

On Mon, Jun 17, 2013 at 12:26:48AM +0200, Andi Shyti wrote:
> > > these two patches provide the etzkx device driver which supports
> > > the following accelerometers:
> > > 
> > >  - Kionix kxcnl
> > >  - Kionix kxtnk
> > >  - ST lisn3dsh
> > > 
> > > Support for ST lis3dsh accelerometer is still in progress.
> > > 
> > > The etzkx accelerometers are a kind of devices that are able to
> > > do gesture recognition directly on the device. It uses two slots
> > > of 16 steps (bytes) each for loading algorithms which perform
> > > gesture recognition.
> > > 
> > > The second patch contains the documentation of the device driver.
> > > 
> > > On http://www.etezian.org/etzkx/etzkx/ is possible to find more
> > > informations about the accelerometer.
> > 
> > Why isn't this a drivers/iio/accel/ driver instead of a misc driver?
> > Please make this an iio driver, then you will be using the correct
> > user/kernel api to talk to your device.
> 
> I was thinking it may be an issue, but it's not iio because the
> time I developed the driver, iio was in the first staging period
> and mainly because the on the board I'm using I cannot update the
> Kernel to use the latest iio.
> 
> I guess you don't like the promise "I can do it later" once the
> supplier sends me a development board (which is planned) :)

Sure, I'll gladly accept "I can do it later" from anyone, as long as you
don't mind my, "I will merge it later" as well :)

Sorry, I can't accept a driver now, that is known to going to be
changing the kernel/user api in the future.  So please, rewrite it to
use IIO, that's what that interface / subsystem is there for.

thanks,

greg k-h

  reply	other threads:[~2013-06-17  2:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-16 21:40 Andi Shyti
2013-06-16 21:40 ` [PATCH 1/2] drivers/misc: etzkx driver for kxcnl/kxtnk accelerometer Andi Shyti
2013-06-16 21:40 ` [PATCH 2/2] Documentation: added etzkx driver documentation Andi Shyti
2013-06-16 21:51 ` [PATCH 0/2] etzkx accelerometer support Greg KH
2013-06-16 22:26   ` Andi Shyti
2013-06-17  2:58     ` Greg KH [this message]
2013-06-17  8:27       ` Andi Shyti
2013-08-08 22:21       ` Andi Shyti
2013-08-08 22:25         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130617025854.GB12522@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andi@etezian.org \
    --cc=arnd@arndb.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oatilla@gmail.com \
    --cc=rob@landley.net \
    --cc=szsolt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®