From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH] tracing: Disable tracing on warning
Date: Mon, 17 Jun 2013 20:32:06 +0200 [thread overview]
Message-ID: <20130617183206.GB3204@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1371487375.18733.18.camel@gandalf.local.home>
On Mon, Jun 17, 2013 at 12:42:55PM -0400, Steven Rostedt wrote:
> Add a traceoff_on_warning option in both the kernel command line as well
> as a sysctl option. When set, any WARN*() function that is hit will cause
> the tracing_on variable to be cleared, which disables writing to the
> ring buffer.
>
> This is useful especially when tracing a bug with function tracing. When
> a warning is hit, the print caused by the warning can flood the trace with
> the functions that producing the output for the warning. This can make the
> resulting trace useless by either hiding where the bug happened, or worse,
> by overflowing the buffer and losing the trace of the bug totally.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Neat;
Acked-by: Peter Zijlstra <peterz@infradead.org>
prev parent reply other threads:[~2013-06-17 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 16:42 Steven Rostedt
2013-06-17 18:32 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617183206.GB3204@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®