From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753037Ab3FRHTp (ORCPT ); Tue, 18 Jun 2013 03:19:45 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:44161 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873Ab3FRHTo (ORCPT ); Tue, 18 Jun 2013 03:19:44 -0400 Date: Tue, 18 Jun 2013 00:19:43 -0700 (PDT) Message-Id: <20130618.001943.965348712833625569.davem@davemloft.net> To: linux@roeck-us.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Frank.Li@freescale.com, jim_baxter@mentor.com Subject: Re: [PATCH] net: fec: Fix build for MCF5272 From: David Miller In-Reply-To: <20130618040312.GA12181@roeck-us.net> References: <1371500179-4733-1-git-send-email-linux@roeck-us.net> <20130617.161151.1327615665309510068.davem@davemloft.net> <20130618040312.GA12181@roeck-us.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck Date: Mon, 17 Jun 2013 21:03:12 -0700 > On Mon, Jun 17, 2013 at 04:11:51PM -0700, David Miller wrote: >> From: Guenter Roeck >> Date: Mon, 17 Jun 2013 13:16:19 -0700 >> >> > Commits 4c09eed9 (net: fec: Enable imx6 enet checksum acceleration) and >> > baa70a5c (net: fec: enable pause frame to improve rx prefomance for 1G >> > network) introduced functionality into the FEC driver which is not >> > supported on MCF5272. As result, building images for MCF5272 fails, >> > complaining about several undefined symbols. >> > >> > Disabled the added functionality for MCF5272 builds. >> > >> > Cc: Frank Li >> > Cc: Jim Baxter >> > Signed-off-by: Guenter Roeck >> > --- >> > Sorry for the added ifdefs. If anyone has a better idea on how to fix >> > the problems, let me know. >> > >> > This problem exists in 3.9 as well. >> >> Does the M5272 not have these registers, or have you simply not added >> defines for where there offsets are in that silicon instance? >> >> I'd much rather you add the register offset defines than pepper the >> entire driver with ifdefs. >> > I agree, and that would have been my preferred solution as well. > Unfortunately, according to the user manual (MCF5272 ColdFire > Integrated Microprocessor User's Manual), the registers do not exist > on this chip. Please explain this in your commit message instead of leaving it as a mystery for the next person who look at this change.