From: Felipe Balbi <balbi@ti.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: <balbi@ti.com>, Michal Marek <mmarek@suse.cz>,
Jeff Mahoney <jeffm@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<jirislaby@gmail.com>, <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
<linux-usb@vger.kernel.org>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
<linux-geode@lists.infradead.org>, <linux-fbdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
<netdev@vger.kernel.org>, Ben Hutchings <ben@decadent.org.uk>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
<tomi.valkeinen@ti.com>
Subject: Re: [PATCH] build some drivers only when compile-testing
Date: Tue, 18 Jun 2013 11:34:26 +0300 [thread overview]
Message-ID: <20130618083425.GI5461@arwen.pp.htv.fi> (raw)
In-Reply-To: <51C01948.9060708@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]
Hi,
On Tue, Jun 18, 2013 at 10:24:40AM +0200, Jiri Slaby wrote:
> >>> Sam Ravnborg (the kconfig ex-maintainer) once wrote that he
> >>> doesn't want to extend the kconfig language for this purpose
> >>> (which I support). That a config option is fine and sufficient
> >>> in this case [1]. Except he called the config option
> >>> "SHOW_ALL_DRIVERS". Adding the current maintainer to CCs ;).
> >>
> >> I agree with Sam. 'depends on XY || COMPILE_TEST' is quite
> >> self-explanatory. And even if it's not, you can look up the help
> >> text for COMPILE_TEST. With "archdepends on" or "available on",
> >> you need to know what to look for to override the dependency.
> >
> > you will still end up with:
> >
> > depends on (ARCH_OMAP || ARCH_EXYNOS || ARCH_DAVINCI || ARCH_PPC ||
> > ...)
> >
> > And every now and again that particular line will be updated to
> > add another arch dependency.
>
> But that is perfectly fine *when* the driver is supported on those
> archs only.
>
> And come on, how much often will this "every now and again" happen? We
> don't have that much cases where a driver is augmented to work on
> another arch or platform. It either works on all of them => doesn't
> need COMPILE_TEST, or work on one or two arches at most.
MUSB alone has 8 different arch choices. Before, it used to be that core
driver was dependendent on all of them, so whenever someone wanted to
build MUSB for another arch, they had to introdude their glue code and
modify the dependency of the core driver.
Also EHCI, it works on pretty much everything, so does DWC3.
DWC3 already has three possibilities but I know of at least 3 others
which could show up soonish.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-18 8:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 9:18 Jiri Slaby
2013-05-23 2:23 ` Greg Kroah-Hartman
2013-05-23 3:09 ` Jeff Mahoney
2013-06-17 20:05 ` Jiri Slaby
2013-06-18 4:51 ` Michal Marek
2013-06-18 8:18 ` Felipe Balbi
2013-06-18 8:24 ` Jiri Slaby
2013-06-18 8:34 ` Felipe Balbi [this message]
2013-06-18 8:44 ` Michal Marek
2013-06-18 8:51 ` Felipe Balbi
2013-06-18 9:21 ` Jiri Slaby
2013-06-19 16:38 ` Mark Brown
2013-06-18 8:35 ` Tomi Valkeinen
2013-06-18 16:04 ` Greg Kroah-Hartman
2013-06-19 6:50 ` Jiri Slaby
2013-06-24 23:42 ` Greg Kroah-Hartman
2013-06-25 8:16 ` Jiri Slaby
2013-06-19 7:10 ` Tomi Valkeinen
2013-06-19 7:12 ` Jiri Slaby
2013-06-19 7:19 ` Tomi Valkeinen
2013-06-19 14:27 ` Greg Kroah-Hartman
2013-06-21 11:11 ` [PATCH v3] " Jiri Slaby
2013-05-23 14:01 ` [PATCH] " Ben Hutchings
2013-05-24 4:50 ` Rob Landley
2013-05-23 7:46 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618083425.GI5461@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.e.keller@intel.com \
--cc=jeffm@suse.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®