From: "Jörn Engel" <joern@logfs.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>,
David Ellingsworth <david@identd.dyndns.org>,
Johannes Berg <johannes@sipsolutions.net>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Michael Buesch <mb@bu3sch.de>,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] softirq: weaken warning in local_bh_enable_ip()
Date: Wed, 19 Jun 2013 18:11:25 -0400 [thread overview]
Message-ID: <20130619221125.GA10834@logfs.org> (raw)
In-Reply-To: <CA+55aFyBL9S9y=kpBte67PfO6EaB79CP3JtMP3KwMWQfo3PrFg@mail.gmail.com>
On Wed, 19 June 2013 12:27:37 -1000, Linus Torvalds wrote:
>
> No the warning is correct, the SCSI target code needs to be fixed. You
> cannot call spin_unlock_bh with interrupts disabled.
That sounds like something coverity could be taught with reasonable
effort - if someone from them is listening. Not sure if sparse has
enough context to do the same.
Just to play thick and make things ultra-clear, you say the following
pattern is never legal, correct?
spin_lock_irq(save)
...
spin_lock_bh
...
spin_unlock_bh
...
spin_unlock_irq(restore)
> So fix the code, don't weaken the warning.
Will do.
Jörn
--
The only real mistake is the one from which we learn nothing.
-- John Powell
prev parent reply other threads:[~2013-06-19 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 16:19 Joern Engel
[not found] ` <CA+55aFyBL9S9y=kpBte67PfO6EaB79CP3JtMP3KwMWQfo3PrFg@mail.gmail.com>
2013-06-19 22:11 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619221125.GA10834@logfs.org \
--to=joern@logfs.org \
--cc=david@identd.dyndns.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=mingo@elte.hu \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome