mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Anders Hammarquist <iko@iko.pp.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] USB: serial: ti_usb_3410_5052: Be explicit about the Abbott product ids being product ids.
Date: Wed, 19 Jun 2013 15:52:45 -0700	[thread overview]
Message-ID: <20130619225245.GA12282@kroah.com> (raw)
In-Reply-To: <201306190021.r5J0LkvQ032449@eskarina.iko.pp.se>

On Wed, Jun 19, 2013 at 01:58:49AM +0200, Anders Hammarquist wrote:
> Be explicit about the Abbott product ids being product ids.
> 
> Signed-off-by: Anders Hammarquist <iko@iko.pp.se>
> ---
>  drivers/usb/serial/ti_usb_3410_5052.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/ti_usb_3410_5052.h b/drivers/usb/serial/ti_usb_3410_5052.h
> index 4a2423e..ea8b273 100644
> --- a/drivers/usb/serial/ti_usb_3410_5052.h
> +++ b/drivers/usb/serial/ti_usb_3410_5052.h
> @@ -52,9 +52,9 @@
>  
>  /* Abbott Diabetics vendor and product ids */
>  #define ABBOTT_VENDOR_ID		0x1a61
> -#define ABBOTT_STEREO_PLUG_ID		0x3410
> +#define ABBOTT_STEREO_PLUG_PRODUCT_ID	0x3410
>  #define ABBOTT_PRODUCT_ID		ABBOTT_STEREO_PLUG_ID

Can you just delete ABBOTT_PRODUCT_ID here, because if you ever use it,
you will get a build error, right?

I'll just take the first patch for now, please resend this one.

thanks,

greg k-h

      reply	other threads:[~2013-06-19 22:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 23:58 [PATCH 2/2] " Anders Hammarquist
2013-06-19 22:52 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130619225245.GA12282@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=iko@iko.pp.se \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome