Re: [PATCH] ipvs: SH fallback and L4 hashing

[Alexander Frolkin <avf@eldamar.org.uk>]

Hi,

> I also noticed some fuzz.
> Alexander, could you double-check ipvs-next to make sure
> that I applied the patch correctly?

I diff'ed my local dev branch with upstream, and the only thing I can
see that has any relation to my patches is:

diff --git a/net/netfilter/ipvs/ip_vs_sh.c b/net/netfilter/ipvs/ip_vs_sh.c
index b7e2c5a..f16c027 100644
--- a/net/netfilter/ipvs/ip_vs_sh.c
+++ b/net/netfilter/ipvs/ip_vs_sh.c
@@ -71,8 +71,8 @@ struct ip_vs_sh_bucket {
 #define IP_VS_SH_TAB_MASK               (IP_VS_SH_TAB_SIZE - 1)
 
 struct ip_vs_sh_state {
-       struct ip_vs_sh_bucket          buckets[IP_VS_SH_TAB_SIZE];
        struct rcu_head                 rcu_head;
+       struct ip_vs_sh_bucket          buckets[IP_VS_SH_TAB_SIZE];
 };
 
 /* Helper function to determine if server is unavailable */

Not sure when or why this changed, but maybe it accounts for the fuzz?


Alex