From: Pavel Machek <pavel@ucw.cz>
To: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Hans J. Koch" <hjk@hansjkoch.de>
Subject: Re: [PATCH char-misc-next] UIO: Fix concurrency issue
Date: Fri, 21 Jun 2013 14:44:32 +0200 [thread overview]
Message-ID: <20130621124431.GA11224@amd.pavel.ucw.cz> (raw)
In-Reply-To: <201306201636.00535.vitas@nppfactor.kiev.ua>
On Thu 2013-06-20 16:36:00, Vitalii Demianets wrote:
> In a SMP case there was a race condition issue between
> uio_pdrv_genirq_irqcontrol() running on one CPU and irq handler on another
> CPU. Fix it by spin_locking shared resources access inside irq handler.
> Also:
> - Change disable_irq to disable_irq_nosync to avoid deadlock, because
> disable_irq waits for the completion of the irq handler;
> - Change atomic bit-manipulation routines to their non-atomic counterparts
> as we already are guarding the code by spinlock.
>
> Signed-off-by: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Sounds good.
Reviewed-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2013-06-21 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 13:36 Vitalii Demianets
2013-06-21 12:44 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621124431.GA11224@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=gregkh@linuxfoundation.org \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vitas@nppfactor.kiev.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®