From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: linux-kernel@vger.kernel.org, asias@redhat.com,
jasowang@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net] vhost-net: fix use-after-free in vhost_net_flush
Date: Mon, 24 Jun 2013 00:01:27 -0700 (PDT) [thread overview]
Message-ID: <20130624.000127.3603241221368993.davem@davemloft.net> (raw)
In-Reply-To: <20130620114813.GA17373@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 20 Jun 2013 14:48:13 +0300
> vhost_net_ubuf_put_and_wait has a confusing name:
> it will actually also free it's argument.
> Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01
Never reference commits only by SHA1 ID, it is never sufficient.
Always provide, after the SHA1 ID, in parenthesis, the header line
from the commit message.
To be honest, I'm kind of tired of telling people they need to do
this over and over again.
Maybe people keep forgetting because the reason why this is an issue
hasn't really sunk in.
If the patch you reference got backported into another tree, it will
not have the SHA1 ID, and therefore someone reading the "fix" won't
be able to find the fault causing change without going through a lot
of trouble. By providing the commit header line you remove that
problem altogether, no ambiguity is possible.
prev parent reply other threads:[~2013-06-24 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 11:48 Michael S. Tsirkin
2013-06-20 12:47 ` Sergei Shtylyov
2013-06-21 6:50 ` Jason Wang
2013-06-21 7:20 ` Asias He
2013-06-24 7:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624.000127.3603241221368993.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=asias@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®