mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch] vfs: check for integer overflows in posix_acl_alloc()
Date: Mon, 24 Jun 2013 19:27:19 +0300	[thread overview]
Message-ID: <20130624162719.GB32503@elgon.mountain> (raw)

We've seen cases where people passed negative numbers to
posix_acl_alloc() and we fixed the caller.  For example 093019cf1b "xfs:
fix acl count validation in xfs_acl_from_disk()".  But there are other
places which might be affected like ext4_acl_from_disk() which checks
for negative but doesn't check an upper limit.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/fs/posix_acl.c b/fs/posix_acl.c
index cea4623..cd7fd2f 100644
--- a/fs/posix_acl.c
+++ b/fs/posix_acl.c
@@ -46,7 +46,12 @@ posix_acl_alloc(int count, gfp_t flags)
 {
 	const size_t size = sizeof(struct posix_acl) +
 	                    count * sizeof(struct posix_acl_entry);
-	struct posix_acl *acl = kmalloc(size, flags);
+	struct posix_acl *acl;
+
+	if (count < 0 || count > (SIZE_MAX - sizeof(struct posix_acl) /
+					sizeof(struct posix_acl_entry)))
+		return NULL;
+	acl = kmalloc(size, flags);
 	if (acl)
 		posix_acl_init(acl, count);
 	return acl;

             reply	other threads:[~2013-06-24 16:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 16:27 Dan Carpenter [this message]
2013-06-24 16:43 ` Dan Carpenter
2013-06-24 21:37 ` Dave Chinner
2013-06-25 13:32   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130624162719.GB32503@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®