Re: [PATCH] misc/bmp085: Enable building as a module

[Eric Andersson <eric.andersson@unixphere.com>]

On 15:10 Mon 24 Jun     , Ben Hutchings wrote:
> Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085
> driver' changed the BMP085 config symbol to a boolean.  I see no
> reason why the shared code cannot be built as a module, so change it
> back to tristate.
> 
> Cc: Eric Andersson <eric.andersson@unixphere.com>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
>  drivers/misc/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index c002d86..7a68184 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -451,7 +451,7 @@ config ARM_CHARLCD
>  	  still useful.
>  
>  config BMP085
> -	bool
> +	tristate
>  	depends on SYSFS
>  
>  config BMP085_I2C
> 

There is no reason for building the common code stand-alone. The BMP085
config option is only selectable via the BMP085_I2C/_SPI options.
See the select-statement for those options:

 config BMP085_I2C
	tristate "BMP085 digital pressure sensor on I2C"
	select BMP085
 ...

-- 
Best regards,
 Eric

 http://www.unixphere.com