From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jeff Layton <jlayton@redhat.com>
Cc: viro@zeniv.linux.org.uk, matthew@wil.cx, bfields@fieldses.org,
dhowells@redhat.com, sage@inktank.com, smfrench@gmail.com,
swhiteho@redhat.com, Trond.Myklebust@netapp.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
cluster-devel@redhat.com, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, piastryyy@gmail.com
Subject: Re: [PATCH v4 06/14] locks: encapsulate the fl_link list handling
Date: Tue, 25 Jun 2013 11:37:04 +1000 [thread overview]
Message-ID: <20130625113704.89a686a55dcec684e5e99434@canb.auug.org.au> (raw)
In-Reply-To: <1371819502-26363-7-git-send-email-jlayton@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
Hi Jeff,
Thanks for doing all this work!
Trivial comments below.
On Fri, 21 Jun 2013 08:58:14 -0400 Jeff Layton <jlayton@redhat.com> wrote:
>
> +static inline void
> +locks_insert_global_locks(struct file_lock *fl)
> +{
> + list_add_tail(&fl->fl_link, &file_lock_list);
> +}
We generally do not use "inline" in C files any more and leave it to the
compiler to do that. Also, without the "inline" these function headers
should all be able to fit on single lines like the others here i.e.
static void locks_insert_global_locks(struct file_lock *fl)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-25 1:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 12:58 [PATCH v4 00/14] locks: scalability improvements for file locking Jeff Layton
2013-06-21 12:58 ` [PATCH v4 01/14] locks: drop the unused filp argument to posix_unblock_lock Jeff Layton
2013-06-21 12:58 ` [PATCH v4 02/14] cifs: use posix_unblock_lock instead of locks_delete_block Jeff Layton
2013-06-21 12:58 ` [PATCH v4 03/14] locks: make generic_add_lease and generic_delete_lease static Jeff Layton
2013-06-21 12:58 ` [PATCH v4 04/14] locks: comment cleanups and clarifications Jeff Layton
2013-06-21 12:58 ` [PATCH v4 05/14] locks: make "added" in __posix_lock_file a bool Jeff Layton
2013-06-21 12:58 ` [PATCH v4 06/14] locks: encapsulate the fl_link list handling Jeff Layton
2013-06-25 1:37 ` Stephen Rothwell [this message]
2013-06-25 10:32 ` Jeff Layton
2013-06-21 12:58 ` [PATCH v4 07/14] locks: protect most of the file_lock handling with i_lock Jeff Layton
2013-06-21 12:58 ` [PATCH v4 08/14] locks: avoid taking global lock if possible when waking up blocked waiters Jeff Layton
2013-06-21 12:58 ` [PATCH v4 09/14] locks: convert fl_link to a hlist_node Jeff Layton
2013-06-21 12:58 ` [PATCH v4 10/14] locks: turn the blocked_list into a hashtable Jeff Layton
2013-06-21 12:58 ` [PATCH v4 11/14] locks: add a new "lm_owner_key" lock operation Jeff Layton
2013-06-21 12:58 ` [PATCH v4 12/14] locks: give the blocked_hash its own spinlock Jeff Layton
2013-06-21 12:58 ` [PATCH v4 13/14] seq_file: add seq_list_*_percpu helpers Jeff Layton
2013-06-21 12:58 ` [PATCH v4 14/14] locks: move file_lock_list to a set of percpu hlist_heads and convert file_lock_lock to an lglock Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625113704.89a686a55dcec684e5e99434@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=ceph-devel@vger.kernel.org \
--cc=cluster-devel@redhat.com \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=piastryyy@gmail.com \
--cc=sage@inktank.com \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
--cc=swhiteho@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®