mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: navin patidar <navinp@cdac.in>
Cc: mfm@muteddisk.com, linux-usb@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: usbip: replace pr_warning() with pr_warn()
Date: Tue, 25 Jun 2013 07:54:28 -0700	[thread overview]
Message-ID: <20130625145428.GA19101@kroah.com> (raw)
In-Reply-To: <CAPV97yePEe4K_yLKjvY2fmjgeL_xvbka=qi-EsoSJasmFtidVg@mail.gmail.com>

On Tue, Jun 25, 2013 at 04:27:18PM +0530, navin patidar wrote:
> On Tue, Jun 25, 2013, Greg KH <gregkh@linuxfoundation.org> said:
> 
> > On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote:
> >> pr_warn() is preferred over pr_warning().
> >
> > And dev_warn() is preferred over both of them, can you convert the code
> > to use that instead?
> >
> 
> struct device is not available in usbip_start_eh()  which is required
> for dev_warn().
> 
> usbip_device's containers struct stub_device and struct  vhci_device
> both have member structure usb_device but inside usbip_start_eh(), it
> is difficult to determine  to which container struct usbip_device
> belongs, thus container_of() can not be used here to get struct
> usb_device.

Then the code should be reworked in order to be able to properly
determine that.

greg k-h

  reply	other threads:[~2013-06-25 14:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 10:57 navin patidar
2013-06-25 14:54 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-06-26  6:42 navin patidar
2013-06-21  9:31 navin patidar
2013-06-24 22:33 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130625145428.GA19101@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mfm@muteddisk.com \
    --cc=navinp@cdac.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome