From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752032Ab3FZIgS (ORCPT ); Wed, 26 Jun 2013 04:36:18 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38935 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865Ab3FZIgO (ORCPT ); Wed, 26 Jun 2013 04:36:14 -0400 Date: Wed, 26 Jun 2013 01:36:11 -0700 (PDT) Message-Id: <20130626.013611.177497936507567378.davem@davemloft.net> To: Alexey.Brodkin@synopsys.com Cc: netdev@vger.kernel.org, andy.shevchenko@gmail.com, romieu@fr.zoreil.com, joe@perches.com, Vineet.Gupta1@synopsys.com, Mischa.Jonker@synopsys.com, arnd@arndb.de, grant.likely@linaro.org, rob.herring@calxeda.com, paul.gortmaker@windriver.com, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, florian@openwrt.org, david.laight@aculab.com Subject: Re: [PATCH] arc_emac: fix compile-time errors & warnings on PPC64 From: David Miller In-Reply-To: <1372232966-11507-1-git-send-email-abrodkin@synopsys.com> References: <1372232966-11507-1-git-send-email-abrodkin@synopsys.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexey Brodkin Date: Wed, 26 Jun 2013 11:49:26 +0400 > As reported by "kbuild test robot" there were some errors and warnings > on attempt to build kernel with "make ARCH=powerpc allmodconfig". > > And this patch addresses both errors and warnings. > Below is a list of introduced changes: > 1. Fix compile-time errors (misspellings in "dma_unmap_single") on PPC. > 2. Use DMA address instead of "skb->data" as a pointer to data buffer. > This fixed warnings on pointer to int conversion on 64-bit systems. > 3. Re-implemented initial allocation of Rx buffers in "arc_emac_open" in > the same way they're re-allocated during operation (receiving packets). > So once again DMA address could be used instead of "skb->data". > 4. Explicitly use EMAC_BUFFER_SIZE for Rx buffers allocation. > > Signed-off-by: Alexey Brodkin Applied.