From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752414Ab3FZTGC (ORCPT ); Wed, 26 Jun 2013 15:06:02 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54031 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633Ab3FZTGA (ORCPT ); Wed, 26 Jun 2013 15:06:00 -0400 Date: Wed, 26 Jun 2013 12:05:58 -0700 From: Andrew Morton To: Bartlomiej Zolnierkiewicz Cc: Vinod Koul , Jassi Brar , Tomasz Figa , Kyungmin Park , linux-kernel@vger.kernel.org Subject: Re: [resend PATCH] DMA: PL330: fix locking in pl330_free_chan_resources() Message-Id: <20130626120558.3a05f4a099822c529912a14c@linux-foundation.org> In-Reply-To: <2690233.kbO94NEnCb@amdc1032> References: <2690233.kbO94NEnCb@amdc1032> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Jun 2013 15:29:15 +0200 Bartlomiej Zolnierkiewicz wrote: > > tasklet_kill() may sleep so call it before taking pch->lock. > > Fixes following lockup: > > [ 345.470000] BUG: scheduling while atomic: cat/2383/0x00000002 Seems rather unpleasant, so I added a cc:stable to the changelog.