From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074Ab3F0P6E (ORCPT ); Thu, 27 Jun 2013 11:58:04 -0400 Received: from merlin.infradead.org ([205.233.59.134]:60653 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258Ab3F0P6D (ORCPT ); Thu, 27 Jun 2013 11:58:03 -0400 Date: Thu, 27 Jun 2013 17:57:48 +0200 From: Peter Zijlstra To: Mel Gorman Cc: Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML Subject: Re: [PATCH 2/8] sched: Track NUMA hinting faults on per-node basis Message-ID: <20130627155748.GX28407@twins.programming.kicks-ass.net> References: <1372257487-9749-1-git-send-email-mgorman@suse.de> <1372257487-9749-3-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372257487-9749-3-git-send-email-mgorman@suse.de> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 26, 2013 at 03:38:01PM +0100, Mel Gorman wrote: > @@ -503,6 +503,18 @@ DECLARE_PER_CPU(struct rq, runqueues); > #define cpu_curr(cpu) (cpu_rq(cpu)->curr) > #define raw_rq() (&__raw_get_cpu_var(runqueues)) > > +#ifdef CONFIG_NUMA_BALANCING > +extern void sched_setnuma(struct task_struct *p, int node, int shared); Stray line; you're introducing that function later with a different signature. > +static inline void task_numa_free(struct task_struct *p) > +{ > + kfree(p->numa_faults); > +} > +#else /* CONFIG_NUMA_BALANCING */ > +static inline void task_numa_free(struct task_struct *p) > +{ > +} > +#endif /* CONFIG_NUMA_BALANCING */ > + > #ifdef CONFIG_SMP > > #define rcu_dereference_check_sched_domain(p) \ > -- > 1.8.1.4 >