mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: Fixup for removing -f option in perf record
Date: Fri, 28 Jun 2013 11:47:38 +0200	[thread overview]
Message-ID: <20130628094738.GA28751@krava.brq.redhat.com> (raw)
In-Reply-To: <20130627104750.GB27378@dyad.programming.kicks-ass.net>

On Thu, Jun 27, 2013 at 12:47:50PM +0200, Peter Zijlstra wrote:
> On Thu, Jun 27, 2013 at 12:39:31PM +0200, Ingo Molnar wrote:
> > 
> > * Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Thu, Jun 27, 2013 at 01:25:20PM +0900, Namhyung Kim wrote:
> > > > From: Namhyung Kim <namhyung.kim@lge.com>
> > > > 
> > > > The commit bf3da4014a0c ("perf record: Remove -f/--force option") got
> > > > rid of -f option from perf record.  But this option was used
> > > > internally by various sub-commands so they wouldn't work anymore.
> > > > Also update the example document not to use -f option.
> > > 
> > > Oh man.. we got rid of -f? Do we now default to over-write existing data
> > > file?
> > 
> > I thought -f was the implied default for ages?
> 
> OK.. I've been dutifully typing it all this while :-)

The '-f' option in record command had no affect.. myabe it got
depreceated when we started to backup perf.data to perf.data.old..?

The report command bails out on following condition:

        if (!force && input_stat.st_uid && (input_stat.st_uid != geteuid())) {

jirka

  reply	other threads:[~2013-06-28  9:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27  4:25 Namhyung Kim
2013-06-27  9:36 ` Peter Zijlstra
2013-06-27 10:39   ` Ingo Molnar
2013-06-27 10:47     ` Peter Zijlstra
2013-06-28  9:47       ` Jiri Olsa [this message]
2013-06-28 14:17         ` David Ahern
2013-06-28 15:37           ` Ingo Molnar
2013-06-28 16:03             ` David Ahern
2013-06-28 16:07               ` Ingo Molnar
2013-07-09  7:41 ` Namhyung Kim
2013-07-09 14:21   ` David Ahern
2013-07-10  0:07     ` Namhyung Kim
2013-07-12  8:50 ` [tip:perf/urgent] perf record: Remove -f/--force option tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130628094738.GA28751@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome