From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Vincent Stehlé" <vincent.stehle@freescale.com>
Cc: <linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, Robin Holt <holt@sgi.com>,
Russell King <linux@arm.linux.org.uk>, <trivial@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH linux-next] ARM: keystone: fix compilation warning
Date: Fri, 28 Jun 2013 10:23:08 +1000 [thread overview]
Message-ID: <20130628102308.d338543da54faccf9bdfe2a5@canb.auug.org.au> (raw)
In-Reply-To: <1372337367-6708-1-git-send-email-vincent.stehle@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]
Hi Vincent,
On Thu, 27 Jun 2013 14:49:27 +0200 Vincent Stehlé <vincent.stehle@freescale.com> wrote:
>
> Fix the following compilation warning:
>
> arch/arm/mach-keystone/keystone.c:74:2: warning: initialization from incompatible pointer type [enabled by default]
> arch/arm/mach-keystone/keystone.c:74:2: warning: (near initialization for ‘__mach_desc_KEYSTONE.restart’) [enabled by default]
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@freescale.com>
> Cc: Robin Holt <holt@sgi.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: trivial@kernel.org
> ---
>
>
> Hi,
>
> This warning was seen on linux-next tag next-20130627, with config ARM
> multi_v7_defconfig.
This is only needed after the merge of the akpm tree, so I will add it
there for today.
> Best regards,
>
> V.
>
>
> arch/arm/mach-keystone/keystone.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c
> index fe4d9ff..b661c5c 100644
> --- a/arch/arm/mach-keystone/keystone.c
> +++ b/arch/arm/mach-keystone/keystone.c
> @@ -49,7 +49,7 @@ static const char *keystone_match[] __initconst = {
> NULL,
> };
>
> -void keystone_restart(char mode, const char *cmd)
> +void keystone_restart(enum reboot_mode mode, const char *cmd)
> {
> u32 val;
>
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-28 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 12:49 Vincent Stehlé
2013-06-28 0:23 ` Stephen Rothwell [this message]
2013-06-28 0:36 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628102308.d338543da54faccf9bdfe2a5@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=holt@sgi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=trivial@kernel.org \
--cc=vincent.stehle@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®