From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: max77693: Skip register regulator if no platform initialization data
Date: Sat, 29 Jun 2013 13:26:48 +0100 [thread overview]
Message-ID: <20130629122648.GO27646@sirena.org.uk> (raw)
In-Reply-To: <1372478659.9121.2.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Sat, Jun 29, 2013 at 12:04:19PM +0800, Axel Lin wrote:
> The code in max77693_pmic_dt_parse_rdata() does skip setting rdata if
> !rmatch[i].init_data. So we may have some empty entries in rdata[].
> We need to skip register regulator if no platform initialization data,
> otherwise we may resiter regulator with invalid settings ( the empty entries
> of rdata[]).
It should be legal to have no init data, this should make the regulator
available read only (allowing the current settings to be read back but
nothing else).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-29 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 4:04 Axel Lin
2013-06-29 12:26 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130629122648.GO27646@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=jonghwa3.lee@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®