From: Andrew Morton <akpm@linux-foundation.org>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run
Date: Mon, 1 Jul 2013 13:45:16 -0700 [thread overview]
Message-ID: <20130701134516.6f043ea9b30ed4fd161704ad@linux-foundation.org> (raw)
In-Reply-To: <1372596791-12968-5-git-send-email-artagnon@gmail.com>
On Sun, 30 Jun 2013 18:23:11 +0530 Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> The cpu-hotplug and memory-hotplug tests don't run:
>
> $ sudo make -C tools/testing/selftests TARGETS=cpu-hotplug run_tests
> /bin/sh: ./on-off-test.sh: Permission denied
>
> $ sudo make -C tools/testing/selftests TARGETS=memory-hotplug run_tests
> /bin/sh: ./on-off-test.sh: Permission denied
>
> Flip the executable bit fixing this.
>
> ...
>
> 2 files changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 tools/testing/selftests/cpu-hotplug/on-off-test.sh
> mode change 100644 => 100755 tools/testing/selftests/memory-hotplug/on-off-test.sh
>
> diff --git a/tools/testing/selftests/cpu-hotplug/on-off-test.sh b/tools/testing/selftests/cpu-hotplug/on-off-test.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/memory-hotplug/on-off-test.sh b/tools/testing/selftests/memory-hotplug/on-off-test.sh
> old mode 100644
> new mode 100755
That won't work. The x bit will too easily get lost again - for
example, patch(1) will rub it out.
This:
--- a/tools/testing/selftests/cpu-hotplug/Makefile~tools-testing-selftests-dont-assume-the-x-bit-is-set-on-scripts
+++ a/tools/testing/selftests/cpu-hotplug/Makefile
@@ -1,6 +1,6 @@
all:
run_tests:
- @./on-off-test.sh || echo "cpu-hotplug selftests: [FAIL]"
+ @/bin/sh ./on-off-test.sh || echo "cpu-hotplug selftests: [FAIL]"
clean:
--- a/tools/testing/selftests/memory-hotplug/Makefile~tools-testing-selftests-dont-assume-the-x-bit-is-set-on-scripts
+++ a/tools/testing/selftests/memory-hotplug/Makefile
@@ -1,6 +1,6 @@
all:
run_tests:
- @./on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
+ @/bin/sh ./on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
clean:
_
prev parent reply other threads:[~2013-07-01 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 12:53 [PATCH 0/4] Minor selftests cleanups Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 1/4] selftests: add .gitignore for vm Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 2/4] selftests: fix clean target in kcmp Makefile Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 3/4] selftests: add .gitignore for kcmp Ramkumar Ramachandra
2013-06-30 12:53 ` [PATCH 4/4] selftests: get {cpu,memory}-hotplug tests to run Ramkumar Ramachandra
2013-07-01 20:45 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701134516.6f043ea9b30ed4fd161704ad@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=artagnon@gmail.com \
--cc=dyoung@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®