mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Greg Price <price@mit.edu>
Cc: linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Namhyung Kim <namhyung@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2] perf report/top: Add option to collapse undesired parts of call graph
Date: Mon, 8 Jul 2013 18:24:52 +0200	[thread overview]
Message-ID: <20130708162452.GB2957@krava.brq.redhat.com> (raw)
In-Reply-To: <20130708115746.GO22203@biohazard-cafe.mit.edu>

On Mon, Jul 08, 2013 at 07:57:46AM -0400, Greg Price wrote:
> On Sun, Jul 07, 2013 at 03:13:40PM +0200, Jiri Olsa wrote:
> > On Mon, Jul 01, 2013 at 10:28:45AM -0400, Greg Price wrote:
> > > For example, in an application with an expensive function
> > > implemented with deeply nested recursive calls, the default
> > > call-graph presentation is dominated by the different callchains
> > > within that function.  By ignoring these callees, we can collect
> > > the callchains leading into the function and compactly identify
> > > what to blame for expensive calls.
> > 
> > hi,
> > what's this one based on? I cannot get it applied on acme's perf/core
> 
> That was on v3.10.  Here it is on 6d895ece5, which is currently acme's
> perf/core.
> 
> Cheers,
> Greg
> 
> 
> -- >8 --
> Date: Thu, 6 Dec 2012 21:48:05 -0800
> 
> For example, in an application with an expensive function
> implemented with deeply nested recursive calls, the default
> call-graph presentation is dominated by the different callchains
> within that function.  By ignoring these callees, we can collect
> the callchains leading into the function and compactly identify
> what to blame for expensive calls.

change looks ok, but I'm not that confident in this part, so at least:

Tested-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

  reply	other threads:[~2013-07-08 16:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01 14:28 Greg Price
2013-07-07 13:13 ` Jiri Olsa
2013-07-08 11:57   ` Greg Price
2013-07-08 16:24     ` Jiri Olsa [this message]
2013-07-08 16:47       ` Arnaldo Carvalho de Melo
2013-07-19  7:50     ` [tip:perf/core] " tip-bot for Greg Price
  -- strict thread matches above, loose matches on Subject: below --
2012-12-07  7:30 [PATCH] perf report: " Greg Price
2013-01-11  5:27 ` Arnaldo Carvalho de Melo
2013-02-25  4:28   ` Greg Price
2013-06-23  3:17   ` Greg Price
2013-06-23 21:53     ` Jiri Olsa
2013-06-24  8:32       ` Ingo Molnar
2013-06-24 23:14         ` Greg Price
2013-06-25  7:47           ` Ingo Molnar
2013-06-25  8:01             ` Namhyung Kim
2013-06-26 22:41               ` Greg Price
2013-06-24 22:50       ` Greg Price
2013-06-26  1:28     ` Namhyung Kim
2013-06-26 22:25       ` Greg Price
2013-06-27  4:58         ` Namhyung Kim
2013-07-01 14:05           ` Greg Price
2013-07-01 14:08           ` [PATCH] perf report: Fix bug in case "--no-call-graph -p foo" Greg Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130708162452.GB2957@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=price@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®