From: Arnd Bergmann <arnd@arndb.de>
To: srinivas.kandagatla@st.com
Cc: linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
Stuart Menefy <stuart.menefy@st.com>,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v1 0/4] ARM: STi fixes and ethernet support
Date: Tue, 9 Jul 2013 09:56:02 +0200 [thread overview]
Message-ID: <201307090956.03191.arnd@arndb.de> (raw)
In-Reply-To: <51DBB629.1050000@st.com>
On Tuesday 09 July 2013, Srinivas KANDAGATLA wrote:
> stmmac (aka "dwmac" a synopsis IP) driver is integrated in to kernel
> sometime in 2.6 series I think :-), and Is used by more than 4 platforms
> in 3.10 kernel. The driver is more generic than it sounds.
> So adding properties/hooks specific to STiH41x SOCs in driver seemed to
> incorrect. Instead doing platform specific bits in the mach via
> callbacks was the only choice I had.
No, you should be using generic interfaces to do the things you need.
I believe what you are missing is an ethernet phy driver that is specific
to your SoC.
Arnd
next prev parent reply other threads:[~2013-07-09 7:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 8:15 Srinivas KANDAGATLA
2013-07-08 8:17 ` [PATCH v1 1/4] ARM: dts: STi: Fix pinconf setup for STiH416 serial2 Srinivas KANDAGATLA
2013-07-08 8:18 ` [PATCH v1 2/4] ARM: STi: Set correct ARM ERRATAs Srinivas KANDAGATLA
2013-07-08 8:18 ` [PATCH v1 3/4] ARM: STi: Add STiH415 ethernet support Srinivas KANDAGATLA
2013-07-08 8:18 ` [PATCH v1 4/4] ARM: STi: Add STiH416 " Srinivas KANDAGATLA
2013-07-08 23:18 ` [PATCH v1 0/4] ARM: STi fixes and " Arnd Bergmann
2013-07-09 7:05 ` Srinivas KANDAGATLA
2013-07-09 7:56 ` Arnd Bergmann [this message]
2013-07-09 10:34 ` Srinivas KANDAGATLA
2013-07-09 21:15 ` Arnd Bergmann
2013-07-10 10:27 ` Srinivas KANDAGATLA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307090956.03191.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=srinivas.kandagatla@st.com \
--cc=stuart.menefy@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome