From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753966Ab3GINqF (ORCPT ); Tue, 9 Jul 2013 09:46:05 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:58097 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753656Ab3GINqB (ORCPT ); Tue, 9 Jul 2013 09:46:01 -0400 Date: Tue, 9 Jul 2013 06:45:58 -0700 From: Tejun Heo To: Konstantin Khlebnikov Cc: Vivek Goyal , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , cgroups@vger.kernel.org, Andrew Morton , Sha Zhengju , devel@openvz.org, Jens Axboe Subject: Re: [PATCH RFC] fsio: filesystem io accounting cgroup Message-ID: <20130709134558.GD2478@htj.dyndns.org> References: <20130708100046.14417.12932.stgit@zurg> <20130708170047.GA18600@mtj.dyndns.org> <20130708175201.GB9094@redhat.com> <20130708175607.GB18600@mtj.dyndns.org> <51DBC99F.4030301@openvz.org> <20130709125734.GA2478@htj.dyndns.org> <51DC0CE2.2050906@openvz.org> <20130709131605.GB2478@htj.dyndns.org> <20130709131646.GC2478@htj.dyndns.org> <51DC136E.6020901@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51DC136E.6020901@openvz.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 09, 2013 at 05:43:10PM +0400, Konstantin Khlebnikov wrote: > My concept it cgroup which would control io operation on vfs layer > for all filesystems. It will account and manage IO operations. I've > found really lightweight technique for accounting and throttling > which don't introduce new locks or priority inversions (which is > major problem in all existing throttlers, including cpu cgroup rate > limiter) So, I've tried to keep code smaller, cleaner and saner as > possible while you guys are trying to push me into the block layer > =) You're trying to implement QoS in the place where you don't have control of the queue itself. You aren't even managing the right type of resource for disks which is time slice rather than iops or bandwidth and by the time you implemented proper hierarchy support and proportional control, yours isn't gonna be that simple either. The root problem is bdi failing to propagate pressure from the actual queue upwards. Fix that. -- tejun