From: Mark Brown <broonie@kernel.org>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: "Nicolas Ferre" <nicolas.ferre@atmel.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Bo Shen" <voice.shen@atmel.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v4 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards
Date: Wed, 10 Jul 2013 11:00:20 +0100 [thread overview]
Message-ID: <20130710100020.GA24508@sirena.org.uk> (raw)
In-Reply-To: <CACQ1gAgHuAcBAAgYaP-n9grrM6X0L9b1mFFfkRg0HH_RnRuXMg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Wed, Jul 10, 2013 at 11:25:37AM +0200, Richard Genoud wrote:
> 2013/7/9 Mark Brown <broonie@kernel.org>:
> > Shouldn't the SSC driver be enforcing this constraint if it comes from
> > the SSC hardware? If the clock is reprogrammable the usual convention
> > for drivers is to not constrain if the clock is set to zero so a machine
> > driver could remove the constraint.
> Actually, my comment is buggy here (or at least, unrelated to the
> authorized rates).
> The "MCLK_RATE" is the master clock of the wm8731 codec (a 12.288MHz crystal).
> According to the datasheet of wm8731, when a 12.288 crystal is used,
> the authorized rates are 8, 32, 48 and 96kHz (I have to remove 16 and
> 64kHz).
> So, is this the right place for the rates ?
No, the CODEC driver should be enforcing the restrictions if that's
where they come from.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-10 10:01 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 13:29 [PATCH v2 0/5] Sound support for at91sam9x5-wm8731 based boards Richard Genoud
2013-07-08 13:29 ` [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud
2013-07-08 14:39 ` [alsa-devel] " Lars-Peter Clausen
2013-07-09 7:37 ` Richard Genoud
2013-07-08 15:07 ` Mark Brown
2013-07-09 8:19 ` Richard Genoud
2013-07-09 8:37 ` Bo Shen
2013-07-09 9:29 ` Mark Brown
2013-07-09 10:27 ` Richard Genoud
2013-07-08 13:29 ` [PATCH v2 2/5] ARM: AT91: DTS: sam9x5: add SSC DMA parameters Richard Genoud
2013-07-08 15:07 ` Mark Brown
2013-07-09 8:27 ` Richard Genoud
2013-07-09 9:32 ` Mark Brown
2013-07-09 9:46 ` Richard Genoud
2013-07-08 13:29 ` [PATCH v2 3/5] ARM: AT91: DTS: sam9x5ek: add WM8731 codec Richard Genoud
2013-07-08 14:36 ` [alsa-devel] " Mark Brown
2013-07-08 13:29 ` [PATCH v2 4/5] ARM: AT91: DTS: sam9x5ek: add sound configuration Richard Genoud
2013-07-08 13:29 ` [PATCH v2 5/5] ARM: AT91: DTS: sam9x5ek: enable SSC Richard Genoud
2013-07-08 13:53 ` [PATCH v2 0/5] Sound support for at91sam9x5-wm8731 based boards Nicolas Ferre
2013-07-09 12:28 ` [PATCH v3 0/7] " Richard Genoud
2013-07-09 12:28 ` [PATCH v3 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud
2013-07-09 12:28 ` [PATCH v3 2/7] Documentation: DT: add sam9x5ek-wm8731 machine driver Richard Genoud
2013-07-09 12:28 ` [PATCH v3 3/7] Documentation: DT: update atmel SSC with DMA binding Richard Genoud
2013-07-09 13:19 ` Richard Genoud
2013-07-09 13:20 ` Nicolas Ferre
2013-07-09 13:31 ` Richard Genoud
2013-07-09 12:28 ` [PATCH v3 4/7] ARM: AT91: DTS: sam9x5: add SSC DMA parameters Richard Genoud
2013-07-09 12:28 ` [PATCH v3 5/7] ARM: AT91: DTS: sam9x5ek: add WM8731 codec Richard Genoud
2013-07-09 12:28 ` [PATCH v3 6/7] ARM: AT91: DTS: sam9x5ek: add sound configuration Richard Genoud
2013-07-09 12:28 ` [PATCH v3 7/7] ARM: AT91: DTS: sam9x5ek: enable SSC Richard Genoud
2013-07-09 14:25 ` [PATCH v4 0/7] Sound support for at91sam9x5-wm8731 based boards Richard Genoud
2013-07-09 14:25 ` [PATCH v4 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud
2013-07-09 14:59 ` Mark Brown
2013-07-10 9:25 ` Richard Genoud
2013-07-10 10:00 ` Mark Brown [this message]
2013-07-10 6:11 ` Bo Shen
2013-07-10 9:30 ` Richard Genoud
2013-07-09 14:25 ` [PATCH v4 2/7] Documentation: DT: add sam9x5ek-wm8731 machine driver Richard Genoud
2013-07-09 15:01 ` Mark Brown
2013-07-10 9:32 ` Richard Genoud
2013-07-09 14:25 ` [PATCH v4 3/7] Documentation: DT: update atmel SSC with DMA binding Richard Genoud
2013-07-09 15:05 ` Mark Brown
2013-07-10 9:48 ` Richard Genoud
2013-07-10 10:01 ` Mark Brown
2013-07-09 14:25 ` [PATCH v4 4/7] ARM: AT91: DTS: sam9x5: add SSC DMA parameters Richard Genoud
2013-07-09 14:25 ` [PATCH v4 5/7] ARM: AT91: DTS: sam9x5ek: add WM8731 codec Richard Genoud
2013-07-09 14:25 ` [PATCH v4 6/7] ARM: AT91: DTS: sam9x5ek: add sound configuration Richard Genoud
2013-07-09 14:25 ` [PATCH v4 7/7] ARM: AT91: DTS: sam9x5ek: enable SSC Richard Genoud
2013-07-09 14:42 ` [PATCH v4 0/7] Sound support for at91sam9x5-wm8731 based boards Mark Brown
2013-07-09 14:52 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710100020.GA24508@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=richard.genoud@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome