From: Thierry Reding <thierry.reding@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Bjorn Helgaas'" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
"'Kukjin Kim'" <kgene.kim@samsung.com>,
Pratyush Anand <pratyush.anand@st.com>,
Mohit KUMAR <Mohit.KUMAR@st.com>,
"'Arnd Bergmann'" <arnd@arndb.de>,
"'Sean Cross'" <xobs@kosagi.com>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'SRIKANTH TUMKUR SHIVANAND'" <ts.srikanth@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] pci: exynos: split into two parts such as Synopsys part and Exynos part
Date: Thu, 11 Jul 2013 08:41:22 -0700 [thread overview]
Message-ID: <20130711154121.GC2198@dhcp-172-17-186-34.nvidia.com> (raw)
In-Reply-To: <001201ce7dfa$716b3370$54419a50$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Thu, Jul 11, 2013 at 02:49:43PM +0900, Jingoo Han wrote:
[...]
> diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile
[...]
> obj-$(CONFIG_PCI_MVEBU) += pci-mvebu.o
> obj-$(CONFIG_PCIE_DW) += pcie-designware.o
> +obj-$(CONFIG_PCI_EXYNOS) += pcie-exynos.o
I think we should keep these sorted alphabetically. Also Tegra and
Marvell are PCIe controllers but they still use the pci- prefix instead
of pcie-. Perhaps it'd be good to keep consistency here? I initially
chose pci- because from a software point of view it doesn't matter all
that much whether it's PCI or PCIe and because the drivers are part of
the PCI subsystem. However if Exynos now uses the pcie- prefix it makes
it look like Tegra and Marvell are plain old PCI.
Thierry
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-11 15:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 5:49 Jingoo Han
2013-07-11 6:40 ` Kishon Vijay Abraham I
2013-07-11 7:05 ` Jingoo Han
2013-07-11 8:35 ` Kishon Vijay Abraham I
2013-07-11 8:54 ` Kishon Vijay Abraham I
2013-07-12 0:00 ` Jingoo Han
2013-07-12 5:23 ` Kishon Vijay Abraham I
2013-07-11 15:41 ` Thierry Reding [this message]
2013-07-11 23:28 ` Jingoo Han
2013-07-12 17:15 ` Thierry Reding
2013-07-15 8:26 ` Jingoo Han
2013-07-12 10:01 ` Kishon Vijay Abraham I
2013-07-12 17:31 ` Thierry Reding
2013-07-15 8:25 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711154121.GC2198@dhcp-172-17-186-34.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=Mohit.KUMAR@st.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pratyush.anand@st.com \
--cc=ts.srikanth@samsung.com \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®