From: Matthijs Kooijman <matthijs@stdin.nl>
To: Julien Delacou <julien.delacou.st@gmail.com>
Cc: Paul Zimmerman <paulz@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grant Likely <grant.likely@linaro.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
devel@driverdev.osuosl.org,
Julien Delacou <julien.delacou@stericsson.com>
Subject: Re: [PATCH] staging: dwc2: fix value used in dwc2_set_all_params
Date: Thu, 11 Jul 2013 17:43:22 +0200 [thread overview]
Message-ID: <20130711154322.GJ10217@login.drsnuggles.stderr.nl> (raw)
In-Reply-To: <1373545450-5251-1-git-send-email-julien.delacou.st@gmail.com>
On Thu, Jul 11, 2013 at 02:24:10PM +0200, Julien Delacou wrote:
> From: Julien Delacou <julien.delacou@stericsson.com>
>
> This fix uses 'value' parameter as it should be instead
> of hardcoded -1.
Woops!
> Signed-off-by: Julien Delacou <julien.delacou@stericsson.com>
> Acked-by: Paul Zimmerman <paulz@synopys.com>
Reviewed-by: Matthijs Kooijman <matthijs@stdin.nl>
> ---
> drivers/staging/dwc2/hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
> index 2ed54b1..ca38aaa 100644
> --- a/drivers/staging/dwc2/hcd.c
> +++ b/drivers/staging/dwc2/hcd.c
> @@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params *params, int value)
> int i;
>
> for (i = 0; i < size; i++)
> - p[i] = -1;
> + p[i] = value;
> }
> EXPORT_SYMBOL_GPL(dwc2_set_all_params);
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-07-11 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 12:24 Julien Delacou
2013-07-11 15:43 ` Matthijs Kooijman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711154322.GJ10217@login.drsnuggles.stderr.nl \
--to=matthijs@stdin.nl \
--cc=devel@driverdev.osuosl.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=julien.delacou.st@gmail.com \
--cc=julien.delacou@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paulz@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®