From: Pavel Machek <pavel@ucw.cz>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Yanmin Zhang <yanmin_zhang@linux.intel.com>,
shuox.liu@intel.com, linux-kernel@vger.kernel.org,
len.brown@intel.com, rjw@sisk.pl, linux-pm@vger.kernel.org
Subject: Re: [PATCH] PM: avoid 'autosleep' in shutdown progress
Date: Sat, 13 Jul 2013 13:56:32 +0200 [thread overview]
Message-ID: <20130713115631.GA16473@amd.pavel.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1307121034180.1469-100000@iolanthe.rowland.org>
On Fri 2013-07-12 10:37:33, Alan Stern wrote:
> On Fri, 12 Jul 2013, Yanmin Zhang wrote:
>
> > On Thu, 2013-07-11 at 16:03 +0800, shuox.liu@intel.com wrote:
> > > From: Liu ShuoX <shuox.liu@intel.com>
> > >
> > > In shutdown progress, system is possible to do power transition
> > > (such as suspend-to-ram) in parallel. It is unreasonable. So,
> > > fixes it by adding a system_state checking and queue try_to_suspend
> > > again when system status is not running.
> > >
> > > Signed-off-by: Liu ShuoX <shuox.liu@intel.com>
> > > ---
> > > kernel/power/autosleep.c | 3 ++-
> > > 1 files changed, 2 insertions(+), 1 deletions(-)
> > >
> > Without this patch, we hit an hang issue on Android.
> >
> > Scenario:
> > Kernel starts shutdown and calls all device driver's shutdown callback.
> > When a driver's shutdown is called, the last wakelock is released and
> > suspend-to-ram starts. However, as some driver's shut down callbacks
> > already shut down devices and disable runtime pm, the suspend-to-ram
> > calls driver's suspend callback without noticing that device is already
> > off and causes crash.
> > We know the drivers should be fixed, but can we also change generic
> > codes a little to make it stronger?
>
> Indeed, this does seem like the sort of thing we want to have.
> Allowing an "automatic" or "opportunistic" sleep in the middle of a
> shutdown makes no sense at all. In fact, it might be a good idea to
> disable system sleep completely at this time -- not even a write to
> /sys/power/state should be allowed to interrupt a shutdown.
I'm not completely sure, but as long as userland is running, we should
have system_state == RUNNING, no?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-07-13 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 8:03 shuox.liu
2013-07-12 6:14 ` Yanmin Zhang
2013-07-12 14:37 ` Alan Stern
2013-07-13 11:56 ` Pavel Machek [this message]
2013-07-15 0:51 ` Yanmin Zhang
2013-07-15 0:16 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130713115631.GA16473@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shuox.liu@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®