Re: [PATCH V1] DA9210 driver files

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

On Mon, Jul 15, 2013 at 03:06:59PM +0100, Steve Twiss wrote:
> From: Steve Twiss <stwiss.opensource@diasemi.com>
> 
> This patch describes the regulator driver for the DA9210 Multi-phase Buck
> from Dialog Semiconductor Ltd. It has been made aginst kernel version
> linux-next next-20130715

To repeat *again* you should submit patches in the format covered in
SubmittingPatches.  This includes things like the commit message, if
your commit message doesn't look like other commit messages for the code
you're changing that's an issue.

> +struct da9210 {
> +	struct device *dev;

This is never used as far as I can tell.

> +MODULE_ALIAS("platform: da9210");

This is for a platform device but this is an I2C device so would never
match.  Also for a platform device the string should have no space in
it.

Otherwise this looks OK, though it'd be better to fill in the register
map information more (listing the valid registers for example).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]