From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Florian Fainelli <florian@openwrt.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Kyungsik Lee <kyungsik.lee@lge.com>,
Michal Marek <mmarek@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-kbuild@vger.kernel.org, x86@kernel.org,
celinux-dev@lists.celinuxforum.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
hyojun.im@lge.com, chan.jeong@lge.com,
Andy Lee <raphael.andy.lee@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Russell King <rmk@arm.linux.org.uk>,
Borislav Petkov <bp@alien8.de>,
Yann Collet <yann.collet.73@gmail.com>,
Chanho Min <chanho.min@lge.com>
Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format
Date: Tue, 16 Jul 2013 11:25:14 +0200 [thread overview]
Message-ID: <201307161125.14491.yann.morin.1998@free.fr> (raw)
In-Reply-To: <CAGVrzcaTMckMKUObknT8abPyOzetuHzWtNPkF=Ae4zz7huShkQ@mail.gmail.com>
Florian, All,
On Tuesday 16 July 2013 11:13:24 Florian Fainelli wrote:
> 2013/7/16 Andrew Morton <akpm@linux-foundation.org>:
> > On Tue, 16 Jul 2013 00:47:27 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> >> On Mon, 15 Jul 2013 15:08:20 -0700 "H. Peter Anvin" <hpa@zytor.com> wrote:
> >>
> >> > On 07/15/2013 03:03 PM, Andrew Morton wrote:
> >> > >
> >> > > I don't know how to do this. Any suggestions?
> >> > >
> >> > > It has to be done at `make config' time. We'd need to probe for the
> >> > > presence of lz4c and then.... what?
> >> > >
> >> > > Is there any precedent for this?
> >> > >
> >> > > I don't think we can just ignore the absence of lz4c - the user has
> >> > > selected a config which his system cannot build. The problem lies
> >> > > within randconfig itself.
> >> > >
> >> >
> >> > We keep running over the need to be able to have kconfig run tests on
> >> > the build system (for toolchain support or for optional tools needed);
> >> > running them in the Makefiles (i.e. at Kbuild time) is simply too late.
> >> >
> >>
> >> Would it make sense to extend Kconfig's `depends'?
> >>
> >> depends on $(shell-command)
> >>
> >> I don't know how practical that would be to implement...
> >
> > Or, easier and faster, run some front-end script which generates
> > once-off Kconfig symbols.
> >
> > if [ -x /bin/lz4c ]
> > then
> > echo CONFIG_HAVE_LZ4C
> > fi
> >
> > then munge the output of that script into the Kconfig run and do
> >
> > depends on HAVE_LZ4C
>
> That does sound nice to avoid the build error, but will eventually
> make it harder to diagnose why the kernel has not been compressed with
> the specific compression tool, some kind of warning should also be
> emitted maybe?
Either a warning at check-time, or a comment in Kconfig, such as:
config COMPRESS_LZ4
depends on HAVE_LZ4
comment "'lz4' missing, LZ4 compression not available"
depends on !HAVE_LZ4
Either way is fine with me. ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'
prev parent reply other threads:[~2013-07-16 9:25 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 8:42 [PATCH -next 1/2] arm: Remove enforced Os flag for LZ4 decompressor Kyungsik Lee
2013-05-06 8:42 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Kyungsik Lee
2013-05-06 9:51 ` Borislav Petkov
2013-07-10 8:12 ` Geert Uytterhoeven
2013-07-10 9:36 ` Borislav Petkov
2013-07-10 18:28 ` Markus Trippelsdorf
2013-07-10 20:01 ` Borislav Petkov
2013-07-11 4:34 ` Kyungsik Lee
2013-07-11 9:46 ` [PATCH] .gitignore: ignore *.lz4 files Markus Trippelsdorf
2013-07-12 7:56 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Ingo Molnar
2013-07-12 8:01 ` Borislav Petkov
2013-07-12 10:13 ` Ingo Molnar
2013-07-12 10:23 ` Borislav Petkov
2013-07-12 11:18 ` Andrew Morton
2013-07-12 12:06 ` Ingo Molnar
2013-07-12 12:13 ` Borislav Petkov
2013-07-12 12:34 ` Florian Fainelli
2013-07-12 12:46 ` Borislav Petkov
2013-07-15 22:03 ` Andrew Morton
2013-07-15 22:08 ` H. Peter Anvin
2013-07-16 7:47 ` Andrew Morton
2013-07-16 7:56 ` Andrew Morton
2013-07-16 8:08 ` Yann E. MORIN
2013-07-16 8:27 ` Andrew Morton
2013-07-16 9:05 ` Borislav Petkov
2013-07-16 9:12 ` Yann E. MORIN
2013-07-16 9:22 ` Borislav Petkov
2013-07-16 9:32 ` Yann E. MORIN
2013-07-16 9:38 ` Borislav Petkov
2013-07-16 9:45 ` Yann E. MORIN
2013-07-16 9:59 ` Borislav Petkov
2013-07-16 10:04 ` Florian Fainelli
2013-07-16 18:04 ` Sam Ravnborg
2013-07-17 21:16 ` Sam Ravnborg
2013-07-17 21:44 ` Borislav Petkov
2013-07-17 22:30 ` Yann E. MORIN
2013-07-17 23:22 ` H. Peter Anvin
2013-07-18 8:02 ` Geert Uytterhoeven
2013-07-18 7:22 ` Geert Uytterhoeven
2013-07-18 7:34 ` Andrew Morton
2013-07-18 7:47 ` Yann E. MORIN
2013-07-18 7:52 ` Andrew Morton
2013-07-18 20:47 ` Sam Ravnborg
2013-07-16 9:13 ` Florian Fainelli
2013-07-16 9:25 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307161125.14491.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=celinux-dev@lists.celinuxforum.org \
--cc=chan.jeong@lge.com \
--cc=chanho.min@lge.com \
--cc=florian@openwrt.org \
--cc=hpa@zytor.com \
--cc=hyojun.im@lge.com \
--cc=kyungsik.lee@lge.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=mmarek@suse.cz \
--cc=raphael.andy.lee@gmail.com \
--cc=rmk@arm.linux.org.uk \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yann.collet.73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®