From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932673Ab3GRKiL (ORCPT ); Thu, 18 Jul 2013 06:38:11 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:33675 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758530Ab3GRKiH (ORCPT ); Thu, 18 Jul 2013 06:38:07 -0400 Date: Thu, 18 Jul 2013 06:37:39 -0400 From: Neil Horman To: Thomas Backlund Cc: Kamal Mostafa , linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com, Prarit Bhargava , Don Zickus , Don Dutile , Bjorn Helgaas , Asit Mallick , David Woodhouse , linux-pci@vger.kernel.org, Joerg Roedel , Konrad Rzeszutek Wilk , Arkadiusz =?utf-8?Q?Mi=C5=9Bkiewicz?= , Luis Henriques Subject: Re: [PATCH 089/145] iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets Message-ID: <20130718103739.GA3626@hmsreliant.think-freely.org> References: <1374101277-7915-1-git-send-email-kamal@canonical.com> <1374101277-7915-90-git-send-email-kamal@canonical.com> <51E7A0F8.9000308@mageia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <51E7A0F8.9000308@mageia.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 18, 2013 at 11:02:00AM +0300, Thomas Backlund wrote: > 18.07.2013 01:47, Kamal Mostafa skrev: > >3.8.13.5 -stable review patch. If anyone has any objections, please let me know. > > > >------------------ > > > >From: Neil Horman > > > >commit 03bbcb2e7e292838bb0244f5a7816d194c911d62 upstream. > > > >A few years back intel published a spec update: > >http://www.intel.com/content/dam/doc/specification-update/5520-and-5500-chipset-ioh-specification-update.pdf > > > >For the 5520 and 5500 chipsets which contained an errata (specificially errata > >53), which noted that these chipsets can't properly do interrupt remapping, and > >as a result the recommend that interrupt remapping be disabled in bios. While > >many vendors have a bios update to do exactly that, not all do, and of course > >not all users update their bios to a level that corrects the problem. As a > >result, occasionally interrupts can arrive at a cpu even after affinity for that > >interrupt has be moved, leading to lost or spurrious interrupts (usually > >characterized by the message: > >kernel: do_IRQ: 7.71 No irq handler for vector (irq -1) > > > >There have been several incidents recently of people seeing this error, and > >investigation has shown that they have system for which their BIOS level is such > >that this feature was not properly turned off. As such, it would be good to > >give them a reminder that their systems are vulnurable to this problem. For > >details of those that reported the problem, please see: > >https://bugzilla.redhat.com/show_bug.cgi?id=887006 > > > >[ Joerg: Removed CONFIG_IRQ_REMAP ifdef from early-quirks.c ] > > > >Signed-off-by: Neil Horman > >CC: Prarit Bhargava > >CC: Don Zickus > >CC: Don Dutile > >CC: Bjorn Helgaas > >CC: Asit Mallick > >CC: David Woodhouse > >CC: linux-pci@vger.kernel.org > >CC: Joerg Roedel > >CC: Konrad Rzeszutek Wilk > >CC: Arkadiusz Miśkiewicz > >Signed-off-by: Joerg Roedel > >Signed-off-by: Luis Henriques > >--- > > arch/x86/include/asm/irq_remapping.h | 2 ++ > > arch/x86/kernel/early-quirks.c | 20 ++++++++++++++++++++ > > drivers/iommu/intel_irq_remapping.c | 10 ++++++++++ > > drivers/iommu/irq_remapping.c | 6 ++++++ > > drivers/iommu/irq_remapping.h | 2 ++ > > 5 files changed, 40 insertions(+) > > > > This patch introduces this warning on 3.8 series kernels: > > In file included from arch/x86/kernel/early-quirks.c:21:0: > /kernel/linux-3.8.13.5/arch/x86/include/asm/irq_remapping.h:46:10: > varning: ”struct irq_data” deklarerad inuti parameterlista > [aktiverat som standard] > /kernel/linux-3.8.13.5/arch/x86/include/asm/irq_remapping.h:46:10: > varning: dess scope-område är endast denna definition eller > deklaration, vilket troligen inte är vad du vill. [aktiverat som > standard] > /kernel/linux-3.8.13.5/arch/x86/include/asm/irq_remapping.h:50:17: > varning: ”struct msi_msg” deklarerad inuti parameterlista [aktiverat > som standard] > > > You need to add this upstream fix too: > > commit 35d3d814cbd46a85bed97cd74ba97fbbb51e0ccd > Author: Joerg Roedel > Date: Fri Apr 19 20:34:55 2013 +0200 > > iommu: Fix compile warnings with forward declarations > I submited a 3.9 backport that included that fix to -stable over a week ago, you should just be able to use that if you want. Neil > > -- > > Thomas > >