From: Felipe Balbi <balbi@ti.com>
To: Rong Wang <wr011235813@gmail.com>
Cc: <balbi@ti.com>, Greg KH <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <Rong.Wang@csr.com>
Subject: Re: [PATCH] usb: udc: add gadget state kobject uevent
Date: Thu, 18 Jul 2013 14:06:28 +0300 [thread overview]
Message-ID: <20130718110628.GI11251@arwen.pp.htv.fi> (raw)
In-Reply-To: <CA+k=oDwvA3eSy7xL7hyBVgjCm37Mv7iroFndJOC09ZQci0=o0A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]
On Thu, Jul 18, 2013 at 06:54:38PM +0800, Rong Wang wrote:
> Hi Felipe,
>
> Here's the patch. If you are OK with it, I'll send it to the list formally.
> Thanks.
>
> -------------------------------------------------------------------------------------------------
>
> usb: gadget: udc-core: make udc state attribute name consistent
>
> The name of udc state attribute file under sysfs is
> registered as "state", while usb_gadget_set_state
> take it as "status" when it's going to update.
> Here it is made consistent as "state".
>
> Signed-off-by: Rong Wang <Rong.Wang@csr.com>
>
> diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
> index ffd8fa5..5514822 100644
> --- a/drivers/usb/gadget/udc-core.c
> +++ b/drivers/usb/gadget/udc-core.c
> @@ -105,7 +105,7 @@ void usb_gadget_set_state(struct usb_gadget *gadget,
> enum usb_device_state state)
> {
> gadget->state = state;
> - sysfs_notify(&gadget->dev.kobj, NULL, "status");
> + sysfs_notify(&gadget->dev.kobj, NULL, "state");
just fix the indentation and prevent gmail from mangling the tabs into
spaces, you're good to go :-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-18 11:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 3:57 Rong Wang
2013-07-15 16:52 ` Greg KH
2013-07-16 3:49 ` Rong Wang
2013-07-16 6:31 ` Greg KH
2013-07-17 2:36 ` Peter Chen
2013-07-18 8:25 ` Rong Wang
2013-07-20 10:57 ` Chen Peter-B29397
2013-07-17 5:50 ` Rong Wang
2013-07-17 7:57 ` Felipe Balbi
2013-07-17 13:04 ` Rong Wang
2013-07-17 13:27 ` Felipe Balbi
2013-07-17 15:37 ` Alan Stern
2013-07-18 8:22 ` Felipe Balbi
2013-07-18 13:50 ` Alan Stern
2013-07-22 9:28 ` Felipe Balbi
2013-07-18 8:33 ` Rong Wang
2013-07-18 8:40 ` Felipe Balbi
2013-07-18 9:28 ` Rong Wang
2013-07-18 10:10 ` Felipe Balbi
2013-07-18 10:54 ` Rong Wang
2013-07-18 11:06 ` Felipe Balbi [this message]
2013-07-26 5:56 ` Barry Song
2013-07-26 15:23 ` Greg KH
2013-07-18 10:08 ` Felipe Balbi
2013-07-17 16:35 ` Greg KH
2013-07-24 9:11 ` Barry Song
2013-07-15 4:58 Rong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718110628.GI11251@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=Rong.Wang@csr.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wr011235813@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®