From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932978Ab3GRQY1 (ORCPT ); Thu, 18 Jul 2013 12:24:27 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:37459 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932660Ab3GRQY0 (ORCPT ); Thu, 18 Jul 2013 12:24:26 -0400 Date: Thu, 18 Jul 2013 17:23:44 +0100 From: Russell King - ARM Linux To: Julien Grall Cc: Stefano Stabellini , Ian Campbell , Patch Tracking , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Olof Johansson Subject: Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled Message-ID: <20130718162344.GZ24642@n2100.arm.linux.org.uk> References: <1373897706-15331-1-git-send-email-julien.grall@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 18, 2013 at 05:15:21PM +0100, Julien Grall wrote: > On 17 July 2013 14:25, Stefano Stabellini > wrote: > > On Mon, 15 Jul 2013, Julien Grall wrote: > >> Even if uncompress debug is disabled, some board will continue to print > >> information during uncompress step. > > > > Are you talking about DEBUG_UNCOMPRESS? > > Should I read the sentence as "even if DEBUG_UNCOMPRESS is not selected, > > some board will continue to print information during the uncompress step"? > > Yes. On the arndale, uncompress log are directly output on UART-2. > This is annoying because Xen doesn't expose the UART to dom0. The DEBUG_UNCOMPRESS option is not about whether the decompressor produces output or not. It is about the implementation of that output. * With non-multiplatform kernels, the output is sent to whatever functions are found in arch/arm/*/include/mach/uncompress.h. * With multiplatform kernels with DEBUG_UNCOMPRESS set, the output is sent using the kernel's LL debug functions. (hence it's name - it's saying that it uses the debug macros.) * With multiplatform kernels without DEBUG_UNCOMPRESS set, there is no way to know where to send the *normal* decompressor output, so we have decided that in this case and this case only, it shall be silent. The final thing to remember is... the normal output from the decompressor is *NOT* debug output. It's informational or error output. Everything here is working as intended.