From: Mark Brown <broonie@kernel.org>
To: "Felipe F. Tonello" <eu@felipetonello.com>
Cc: alsa-devel@alsa-project.org, LiamGirdwoodlgirdwood@gmail.com,
JaroslavKyselaperex@perex.cz, TakashiIwaitiwai@suse.de,
linux-kernel@vger.kernel.org,
"Felipe F. Tonello" <ftonello@cercacor.com>
Subject: Re: [PATCH] ALSA: SoC: Added jack detection kcontrol support
Date: Mon, 22 Jul 2013 01:01:58 +0100 [thread overview]
Message-ID: <20130722000157.GI9858@sirena.org.uk> (raw)
In-Reply-To: <1374281962-3786-1-git-send-email-eu@felipetonello.com>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
On Fri, Jul 19, 2013 at 05:59:22PM -0700, Felipe F. Tonello wrote:
> From: "Felipe F. Tonello" <ftonello@cercacor.com>
>
> It adds soc jack support for alsa kcontrol.
>
> This support is necessary since the new kcontrol is used by user-space
> daemons, such as PulseAudio(>=2.0), to do jack detection.
>
> Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
> ---
> include/sound/soc.h | 1 +
> sound/soc/Kconfig | 1 +
> sound/soc/soc-jack.c | 22 ++++++++++++++++++++++
> 3 files changed, 24 insertions(+)
No, this makes no sense at all as an ASoC specific feature - it should
be a standard feature of ALSA jacks. The whole point of having ALSA
core infrastructure for jacks is to avoid having to go round doing make
work stuff like this.
The fact that the kcontrols were introduced as a HDA-specific feature at
all is of course a problem here...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next parent reply other threads:[~2013-07-22 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1374281962-3786-1-git-send-email-eu@felipetonello.com>
2013-07-22 0:01 ` Mark Brown [this message]
2013-07-22 21:11 ` Felipe Tonello
2013-07-23 12:40 ` Mark Brown
2013-07-24 0:10 ` Felipe Tonello
2013-07-24 0:13 ` Mark Brown
2013-07-24 6:16 ` [alsa-devel] " David Henningsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722000157.GI9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=JaroslavKyselaperex@perex.cz \
--cc=LiamGirdwoodlgirdwood@gmail.com \
--cc=TakashiIwaitiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=eu@felipetonello.com \
--cc=ftonello@cercacor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome