From: Michal Hocko <mhocko@suse.cz>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Don Zickus <dzickus@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC -v2 2/2] watchdog: update watchdog_tresh properly
Date: Mon, 22 Jul 2013 14:47:54 +0200 [thread overview]
Message-ID: <20130722124754.GC24400@dhcp22.suse.cz> (raw)
In-Reply-To: <1374493502-31907-1-git-send-email-mhocko@suse.cz>
On Mon 22-07-13 13:45:02, Michal Hocko wrote:
[...]
> @@ -486,7 +486,50 @@ static struct smp_hotplug_thread watchdog_threads = {
> .unpark = watchdog_enable,
> };
>
> -static int watchdog_enable_all_cpus(void)
> +static void restart_watchdog_hrtimer(void *info)
> +{
> + struct hrtimer *hrtimer = &__raw_get_cpu_var(watchdog_hrtimer);
> +
> + hrtimer_restart(hrtimer);
Ohh, scratch that. This is not sufficient because the the new sampling
period is not considered. I will repost updated version soon
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2013-07-22 12:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 9:04 [RFC 1/2] watchdog: update watchdog attributes atomically Michal Hocko
2013-07-19 9:04 ` [RFC 2/2] watchdog: update watchdog_tresh properly Michal Hocko
2013-07-19 16:08 ` Don Zickus
2013-07-19 16:37 ` Michal Hocko
2013-07-19 18:05 ` Don Zickus
2013-07-20 8:42 ` Michal Hocko
2013-07-22 11:45 ` [RFC -v2 " Michal Hocko
2013-07-22 12:47 ` Michal Hocko [this message]
2013-07-22 14:32 ` [RFC -v3 " Michal Hocko
2013-07-23 13:53 ` Don Zickus
2013-07-23 14:07 ` Michal Hocko
2013-07-23 14:44 ` Don Zickus
2013-07-23 14:51 ` Michal Hocko
2013-07-19 16:10 ` [RFC 1/2] watchdog: update watchdog attributes atomically Don Zickus
2013-07-19 16:33 ` Michal Hocko
2013-07-23 13:56 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722124754.GC24400@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome