mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: irq: Acknowledge also interrupts that are masked
Date: Mon, 22 Jul 2013 14:30:52 +0100	[thread overview]
Message-ID: <20130722133052.GT9858@sirena.org.uk> (raw)
In-Reply-To: <1374491474.4355.12.camel@pizza.hi.pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

On Mon, Jul 22, 2013 at 01:11:14PM +0200, Philipp Zabel wrote:
> Am Montag, den 22.07.2013, 11:08 +0100 schrieb Mark Brown:

> > what happens for masked interrupts.  Though based on your description of
> > the problem it sounds like a quirk to ack interrupts immediately after
> > masking them might do the trick instead of the full on always ack
> > behaviour.

> thanks, this seems to work, too:

Great.  I think a quirk might still be in order in case something is
relying on the interrupts still being asserted (eg, for handover after
boot) and it needs to check if ack_base is defined (for clear on read
interrupt controllers) but otherwise that looks good for upstream if you
want to send a patch?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2013-07-22 13:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22  9:24 Philipp Zabel
2013-07-22 10:08 ` Mark Brown
2013-07-22 11:11   ` Philipp Zabel
2013-07-22 13:30     ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130722133052.GT9858@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®