From: Mark Brown <broonie@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regmap: irq: document mask/wake_invert, make them bool for consistency
Date: Tue, 23 Jul 2013 20:39:01 +0100 [thread overview]
Message-ID: <20130723193901.GR9858@sirena.org.uk> (raw)
In-Reply-To: <1374506153-10092-2-git-send-email-p.zabel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
On Mon, Jul 22, 2013 at 05:15:53PM +0200, Philipp Zabel wrote:
> - unsigned int mask_invert;
> - unsigned int wake_invert;
> + bool mask_invert;
> + bool wake_invert;
Actually we should probably make these bitfields and convert the other
booleans to bitfields, sadly the C bool type is equivalent to an int not
a bitfield so is more wasteful.
You shouldn't have mixed this in with the documentation fix...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-23 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 15:15 [PATCH 1/2] regmap: irq: Allow to acknowledge masked interrupts during initialization Philipp Zabel
2013-07-22 15:15 ` [PATCH 2/2] regmap: irq: document mask/wake_invert, make them bool for consistency Philipp Zabel
2013-07-23 19:39 ` Mark Brown [this message]
2013-07-23 19:39 ` [PATCH 1/2] regmap: irq: Allow to acknowledge masked interrupts during initialization Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723193901.GR9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®