From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934066Ab3GWUSr (ORCPT ); Tue, 23 Jul 2013 16:18:47 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:51654 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932447Ab3GWUSq (ORCPT ); Tue, 23 Jul 2013 16:18:46 -0400 Date: Tue, 23 Jul 2013 15:18:23 -0500 From: "Philip J. Kelleher" To: axboe@kernel.dk Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/4] rsxx: Removing IDA on driver unload. Message-ID: <20130723201823.GC12914@oc6784271780.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13072320-5518-0000-0000-00001092F9A6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philip J Kelleher The driver was not releasing the IDA entry during driver unload. Signed-off-by: Philip J Kelleher ------------------------------------------------------------------------------- diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/core.c linux-block/drivers/block/rsxx/core.c --- linux-block-vanilla/drivers/block/rsxx/core.c 2013-07-23 10:11:20.943772116 -0500 +++ linux-block/drivers/block/rsxx/core.c 2013-07-23 10:14:50.402462948 -0500 @@ -1105,6 +1105,10 @@ static void rsxx_pci_remove(struct pci_d pci_disable_device(dev); pci_release_regions(dev); + spin_lock(&rsxx_ida_lock); + ida_remove(&rsxx_disk_ida, card->disk_id); + spin_unlock(&rsxx_ida_lock); + kfree(card); }