mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Linux Containers <containers@lists.linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [REVIEW][PATCH] vfs: Lock in place mounts from more privileged users
Date: Wed, 24 Jul 2013 15:30:18 +0000	[thread overview]
Message-ID: <20130724153018.GA17960@mail.hallyn.com> (raw)
In-Reply-To: <20130724124933.GA16517@mail.hallyn.com>

Quoting Serge E. Hallyn (serge@hallyn.com):
> Quoting Eric W. Biederman (ebiederm@xmission.com):
> > 
> > Serge does this patch break lxc?  I think all should be well but I want
> > to make certain there is not some hidden case where this fundamentaly
> > breaks some functionality.
> 
> I haven't yet tried.  I'll build and test a kernel today.  I'm pretty
> sure all the child's mounts are done after clone, so I *think* the worst
> case will be that the unmounting of put_old after pivot_root() will
> be noisy.  Will let you know.
> 
> -serge

Just tested it - works fine.  Warns about all of the failed umounts.

Acked-by: Serge Hallyn <serge.hallyn@canonical.com>

( Mind you I'm not approving of the idea of hiding mounts as a security
mechanisms, but I know that neither are you :)

thanks,
-serge

  reply	other threads:[~2013-07-24 15:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 18:30 Eric W. Biederman
2013-07-24  1:15 ` Andy Lutomirski
2013-07-24  6:50   ` Eric W. Biederman
2013-07-24 12:49     ` Serge E. Hallyn
2013-07-24 15:30       ` Serge E. Hallyn [this message]
2013-07-24 16:05         ` Eric W. Biederman
2013-07-24 16:49           ` Serge E. Hallyn
2013-07-24 15:46     ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724153018.GA17960@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome