From: Mark Brown <broonie@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Krystian Garbaciak <krystian.garbaciak@diasemi.com>
Subject: Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.
Date: Wed, 24 Jul 2013 18:07:21 +0100 [thread overview]
Message-ID: <20130724170721.GQ9858@sirena.org.uk> (raw)
In-Reply-To: <1374683683-13370-2-git-send-email-p.zabel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Wed, Jul 24, 2013 at 06:34:42PM +0200, Philipp Zabel wrote:
> + ret = regmap_read(da9063->regmap, DA9063_REG_CHIP_ID, &model);
> + if (ret < 0) {
> + dev_err(da9063->dev, "Cannot read chip model id.\n");
> + return -EIO;
> + }
> +
> + ret = regmap_read(da9063->regmap, DA9063_REG_CHIP_VARIANT, &revision);
> + if (ret < 0) {
> + dev_err(da9063->dev, "Cannot read chip revision id.\n");
> + return -EIO;
> + }
Is it possible to valiate these at all?
> +static int __init da9063_i2c_init(void)
> +{
> + int ret;
> +
> + ret = i2c_add_driver(&da9063_i2c_driver);
> + if (ret != 0)
> + pr_err("Failed to register da9063 I2C driver\n");
> +
> + return ret;
> +}
> +subsys_initcall(da9063_i2c_init);
You should really be able to use module_i2c_driver() for modern systems,
probe deferral should resolve the init order issues.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-24 17:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 16:34 [PATCH 0/2] Add Dialog DA9063 core and regulator drivers Philipp Zabel
2013-07-24 16:34 ` [PATCH 1/2] mfd: Add Dialog DA9063 core driver Philipp Zabel
2013-07-24 17:07 ` Mark Brown [this message]
2013-07-25 11:00 ` Philipp Zabel
2013-07-25 8:04 ` Lee Jones
2013-07-25 8:08 ` Lee Jones
2013-07-25 17:34 ` Philipp Zabel
2013-07-25 18:00 ` Mark Brown
2013-07-29 15:46 ` Lee Jones
2013-07-29 15:57 ` Samuel Ortiz
2013-07-29 15:57 ` Philipp Zabel
2013-07-24 16:34 ` [PATCH 2/2] regulator: Add Dialog DA9063 voltage regulators support Philipp Zabel
2013-07-24 17:29 ` Mark Brown
2013-07-25 17:35 ` Philipp Zabel
2013-07-25 18:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724170721.GQ9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=krystian.garbaciak@diasemi.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®