From: Borislav Petkov <bp@alien8.de>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>, Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] APEI/ERST: Fix error message formatting
Date: Wed, 24 Jul 2013 20:10:56 +0200 [thread overview]
Message-ID: <20130724181056.GM30777@pd.tnic> (raw)
In-Reply-To: <20130724171347.GB29756@naverao1-tp.watson.ibm.com>
On Wed, Jul 24, 2013 at 10:43:47PM +0530, Naveen N. Rao wrote:
> While looking at this, I noticed that we seem to be using varying
> field widths in our APEI code: - einj.c has two instances using
> %#010llx. - apei-base.c uses widths of 10 (4 bytes) and 6 (2 bytes).
>
> Not sure if these are intentional and those fields truly aren't 64-bit
> (as suggested by the usage of long long int).
That's an interesting question but I think you're better fitted to
answer it - I try to avoid the APEI spec as much as possible.
:-)
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
prev parent reply other threads:[~2013-07-24 18:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 21:01 Borislav Petkov
2013-07-22 21:24 ` Kees Cook
2013-07-24 17:13 ` Naveen N. Rao
2013-07-24 17:23 ` Joe Perches
2013-07-25 11:23 ` Naveen N. Rao
2013-07-25 17:32 ` Bjorn Helgaas
2013-07-29 13:58 ` Borislav Petkov
2013-07-29 14:28 ` Bjorn Helgaas
2013-07-29 14:40 ` Borislav Petkov
2013-07-29 14:50 ` Bjorn Helgaas
2013-07-29 15:22 ` Borislav Petkov
2013-07-29 15:32 ` Joe Perches
2013-07-29 16:12 ` Bjorn Helgaas
2013-07-31 9:23 ` Borislav Petkov
2013-07-31 9:57 ` Naveen N. Rao
2013-07-31 9:46 ` Naveen N. Rao
2013-07-31 18:00 ` Bjorn Helgaas
2013-08-01 10:10 ` Naveen N. Rao
2013-07-24 18:10 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724181056.GM30777@pd.tnic \
--to=bp@alien8.de \
--cc=anton@enomsg.org \
--cc=bp@suse.de \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=rjw@sisk.pl \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®