Re: [PATCH 4/5] Intel MIC Card Driver Changes for Virtio Devices.

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Jul 24, 2013 at 08:31:35PM -0700, Sudeep Dutt wrote:
> +/*
> + * Intel MIC Platform Software Stack (MPSS)
> + *
> + * Copyright(c) 2013 Intel Corporation.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License, version 2, as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
> + * USA.
> + *
> + * The full GNU General Public License is included in this distribution in
> + * the file called "COPYING".

Someone needs to tell Intel to take out the address paragraph of thier
"standard template" as it's annoying.  Please remove it, unless you
personally want to keep the file up to date with the address movements
of the FSF for the next 40+ years.

> + * Disclaimer: The codes contained in these modules may be specific to
> + * the Intel Software Development Platform codenamed: Knights Ferry, and
> + * the Intel product codenamed: Knights Corner, and are not backward
> + * compatible with other Intel products. Additionally, Intel will NOT
> + * support the codes or instruction set in future products.

What does this mean?  That's a new one to me...

> +static inline struct device *dev(struct mic_vdev *mvdev)
> +{
> +	return mvdev->vdev.dev.parent;
> +}

Can you pick a worse name?  And you aren't returning the "device", you
are returning the parent, so the name (as short as it is), is wrong.


ick.

greg k-h