From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755185Ab3GYICR (ORCPT ); Thu, 25 Jul 2013 04:02:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34043 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752341Ab3GYICI (ORCPT ); Thu, 25 Jul 2013 04:02:08 -0400 Date: Thu, 25 Jul 2013 10:02:05 +0200 From: Michal Hocko To: Li Zefan Cc: Andrew Morton , KAMEZAWA Hiroyuki , Johannes Weiner , LKML , linux-mm@kvack.org, Cgroups , Tejun Heo Subject: Re: [PATCH] memcg: remove redundant code in mem_cgroup_force_empty_write() Message-ID: <20130725080205.GE12818@dhcp22.suse.cz> References: <51F08505.6050402@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51F08505.6050402@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 25-07-13 09:53:09, Li Zefan wrote: > vfs guarantees the cgroup won't be destroyed, so it's redundant > to get a css reference. > > Signed-off-by: Li Zefan Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 03c8bf7..aa3e478 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5015,15 +5015,10 @@ static int mem_cgroup_force_empty(struct mem_cgroup *memcg) > static int mem_cgroup_force_empty_write(struct cgroup *cont, unsigned int event) > { > struct mem_cgroup *memcg = mem_cgroup_from_cont(cont); > - int ret; > > if (mem_cgroup_is_root(memcg)) > return -EINVAL; > - css_get(&memcg->css); > - ret = mem_cgroup_force_empty(memcg); > - css_put(&memcg->css); > - > - return ret; > + return mem_cgroup_force_empty(memcg); > } > > > -- > 1.8.0.2 -- Michal Hocko SUSE Labs