mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de,
	torvalds@linux-foundation.org
Subject: Re: [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h v3
Date: Fri, 26 Jul 2013 00:06:17 +0100	[thread overview]
Message-ID: <20130725230617.GE13295@cantiga.alporthouse.com> (raw)
In-Reply-To: <1374770269-3223-2-git-send-email-jbarnes@virtuousgeek.org>

On Thu, Jul 25, 2013 at 09:37:48AM -0700, Jesse Barnes wrote:
> For use by userspace (at some point in the future) and other kernel code.
> 
> v2: move PCI IDs to uabi (Chris)
>     move PCI IDs to drm/ (Dave)
> v3: fixup Quanta detection - needs to come first (Daniel)

One last comment!

> +#define INTEL_VGA_DEVICE(id, info) {		\
> +	.class = PCI_BASE_CLASS_DISPLAY << 16,	\
> +	.class_mask = 0xff0000,			\
> +	.vendor = 0x8086,			\
> +	.device = id,				\
> +	.subvendor = PCI_ANY_ID,		\
> +	.subdevice = PCI_ANY_ID,		\
> +	.driver_data = (unsigned long) info }

libpciaccess doesn't define either PCI_BASE_CLASS_DISPLAY or PCI_ANY_ID.
Since we use the hex values for the rest of the elements, it would seem
to be tidier to also use 0x3 << 16 instead of PCI_BASE_CLASS_DISPLAY << 16.
I would leave PCI_ANY_ID as a symbolic value though.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2013-07-25 23:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 16:37 Ugly patches for stolen reservation Jesse Barnes
2013-07-25 16:37 ` [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h v3 Jesse Barnes
2013-07-25 23:06   ` Chris Wilson [this message]
2013-07-25 16:37 ` [PATCH 2/2] x86: add early quirk for reserving Intel graphics stolen memory v3 Jesse Barnes
2013-07-25 22:42   ` Chris Wilson
2013-07-25 22:59     ` Chris Wilson
2013-07-25 23:18       ` Jesse Barnes
2013-07-26  8:10   ` [Intel-gfx] " Daniel Vetter
2013-07-26 16:58   ` H. Peter Anvin
2013-07-26 17:12     ` Jesse Barnes
2013-07-25 20:05 ` Ugly patches for stolen reservation Ingo Molnar
2013-07-25 20:16   ` Jesse Barnes
2013-07-25 22:10     ` [Intel-gfx] " Daniel Vetter
2013-07-25 22:42   ` H. Peter Anvin
2013-07-25 23:17     ` Jesse Barnes
2013-07-26  0:49       ` H. Peter Anvin
2013-07-26  0:31     ` Linus Torvalds
2013-07-26  0:48       ` H. Peter Anvin
2013-07-26 17:52         ` [Intel-gfx] " Daniel Vetter
2013-07-26 15:51       ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130725230617.GE13295@cantiga.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=hpa@zytor.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®